From: Sean Christopherson <seanjc@google.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
Oliver Upton <oupton@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Check the right feature bit for MSR_KVM_ASYNC_PF_ACK access
Date: Thu, 22 Jul 2021 17:19:34 +0000 [thread overview]
Message-ID: <YPmopoGY4hwuVHAp@google.com> (raw)
In-Reply-To: <20210722123018.260035-1-vkuznets@redhat.com>
On Thu, Jul 22, 2021, Vitaly Kuznetsov wrote:
> MSR_KVM_ASYNC_PF_ACK MSR is part of interrupt based asynchronous page fault
> interface and not the original (deprecated) KVM_FEATURE_ASYNC_PF. This is
> stated in Documentation/virt/kvm/msr.rst.
>
> Fixes: 66570e966dd9 ("kvm: x86: only provide PV features if enabled in guest's CPUID")
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> arch/x86/kvm/x86.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index d715ae9f9108..88ff7a1af198 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3406,7 +3406,7 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
> return 1;
> break;
> case MSR_KVM_ASYNC_PF_ACK:
> - if (!guest_pv_has(vcpu, KVM_FEATURE_ASYNC_PF))
> + if (!guest_pv_has(vcpu, KVM_FEATURE_ASYNC_PF_INT))
Do we want to require both, or do we want to let userspace be stupid?
> return 1;
> if (data & 0x1) {
> vcpu->arch.apf.pageready_pending = false;
> @@ -3745,7 +3745,7 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
> msr_info->data = vcpu->arch.apf.msr_int_val;
> break;
> case MSR_KVM_ASYNC_PF_ACK:
> - if (!guest_pv_has(vcpu, KVM_FEATURE_ASYNC_PF))
> + if (!guest_pv_has(vcpu, KVM_FEATURE_ASYNC_PF_INT))
> return 1;
>
> msr_info->data = 0;
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-07-22 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 12:30 [PATCH] KVM: x86: Check the right feature bit for MSR_KVM_ASYNC_PF_ACK access Vitaly Kuznetsov
2021-07-22 12:39 ` Maxim Levitsky
2021-07-22 15:40 ` Oliver Upton
2021-07-22 17:19 ` Sean Christopherson [this message]
2021-07-23 6:58 ` Vitaly Kuznetsov
2021-07-26 12:27 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPmopoGY4hwuVHAp@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).