From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F04C4332F for ; Thu, 2 Sep 2021 19:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D5A761104 for ; Thu, 2 Sep 2021 19:55:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347462AbhIBT4C (ORCPT ); Thu, 2 Sep 2021 15:56:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32414 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347449AbhIBT4C (ORCPT ); Thu, 2 Sep 2021 15:56:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630612502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0KZsLb+dQjO46E/gdx6NrK5aykQFxATsK6Vcg3WdPIc=; b=hAloLV/AVG6b48mWgRARQkNafnmYdGnFsl8yggstcoTEb+rgCpHjrlWM6DLYZLZy5BMFp4 0egjAW8f6BHCNi8ydnLJQO0LO6a2VA7GlblrRzvgW4gg0fERELo63ELfbBQNnD3Xxc86pM m86KxwZvMQLBIxymZEQekxacrmI5U4A= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-1-C3wKhQQVMvKMPdF2QddXDQ-1; Thu, 02 Sep 2021 15:53:54 -0400 X-MC-Unique: C3wKhQQVMvKMPdF2QddXDQ-1 Received: by mail-qk1-f200.google.com with SMTP id o4-20020ae9f504000000b003d39d97b227so3465750qkg.2 for ; Thu, 02 Sep 2021 12:53:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0KZsLb+dQjO46E/gdx6NrK5aykQFxATsK6Vcg3WdPIc=; b=Y9ieKjRY/cr32LVGd1kzQ4RbjM/q2qKFotHmLcEgb6N1uZYKF5aXBLD28FPYT6DxnV Oa/AnSmH5zWWrWoxjZpK3uHEtbI0WfKhEClxXqJg6s+iS4S25+izqJv/v89yD89K8yjR ZqlrlN+1jEGvg8j+VJSxhCuOZAfwcxjTSOo+O+WMcDyBtyOt0iOkHEo2NonVFFaYKEqc he5j1gaduRKbOjGbUtHaNH+gxZd6PPFkz1SLYryBfNGlbzOujSx95bcIXSUcT2SEEsc8 bHzMyEeHATRvVtDIYmQXX0i1YFrNRWMh1dSZSMi4AsqG0A2cFBYrD4trpcOKObYdZVOT 4M1Q== X-Gm-Message-State: AOAM533GLq/FDXgx9GP2cqFDt/MkKL6kGmSS+000eYvwMiaV5uiP3X+/ BCZUq7fb/p7i4JAcWIWTsXgrqqvJfCgPuU2rYbwh0EjYut25234PhHujkqQP+8mtIS52ogSh5Hc udyPnYXUu1LkY X-Received: by 2002:a05:6214:c3:: with SMTP id f3mr35450qvs.1.1630612434425; Thu, 02 Sep 2021 12:53:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfe+gUFrTXtomtVX2xlzkNBTFg7I3mOh//TVRKhgiquDY4WnrhWTNbYNyI7qpkd/xsfAo6rw== X-Received: by 2002:a05:6214:c3:: with SMTP id f3mr35435qvs.1.1630612434225; Thu, 02 Sep 2021 12:53:54 -0700 (PDT) Received: from t490s ([2607:fea8:56a3:500::ad7f]) by smtp.gmail.com with ESMTPSA id l11sm1625458qtv.88.2021.09.02.12.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 12:53:53 -0700 (PDT) Date: Thu, 2 Sep 2021 15:53:51 -0400 From: Peter Xu To: Vitaly Kuznetsov Cc: Sean Christopherson , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , kernel test robot Subject: Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested() Message-ID: References: <20210901230506.13362-1-peterx@redhat.com> <87y28flyxj.fsf@vitty.brq.redhat.com> <87r1e7lycp.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87r1e7lycp.fsf@vitty.brq.redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Sep 02, 2021 at 06:46:14PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > On Thu, Sep 02, 2021, Vitaly Kuznetsov wrote: > >> Peter Xu writes: > >> > >> > Drop the unused function as reported by test bot. > >> > >> Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in > >> reallity you drop "kvm_dirty_gfn_invalid()". > > > > Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful > > to reviewers to respond to your own patch if there's a fatal mistake and you're > > going to immediately post a new version. For tiny patches it's not a big deal, > > but for larger patches it can avoid wasting reviewers' time. > > > > Indeed. It's also a good reminder for reviewers that inbox is best > treated like a stack and not like a queue :-) It should really be a queue, to be fair. :) I normally glance all the emails before looking into the details. But that's not an excuse for sure, I should have NACKed that one. Sorry about that. -- Peter Xu