From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382A1C433F5 for ; Fri, 1 Oct 2021 13:03:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 12EA261A8B for ; Fri, 1 Oct 2021 13:03:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353866AbhJANEq (ORCPT ); Fri, 1 Oct 2021 09:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353738AbhJANEp (ORCPT ); Fri, 1 Oct 2021 09:04:45 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7691C061775; Fri, 1 Oct 2021 06:03:01 -0700 (PDT) Received: from zn.tnic (p200300ec2f0e8e00c9205f48360a92d6.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:8e00:c920:5f48:360a:92d6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4DFB81EC05BF; Fri, 1 Oct 2021 15:03:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1633093380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Pww6+dMpzZfasK3x5P00rVcRmv+YdyobAl7XmL8o1hQ=; b=UPoCccmafl2kj4ZfjkRANSs2qzDvdnHfjG51lKFvLOwkF4ENeK9ENX3ewAMPoJY36xSu1g s+vucdZRWDPD9eq8FW57/jUSDnwGFsRUHn9t6CMr+f71s76rhviCESLb4QpZWHhAnhg015 UUFkcN2vhdLDHQriiIKjCj6JDq5eIQI= Date: Fri, 1 Oct 2021 15:03:01 +0200 From: Borislav Petkov To: Marc Orr Cc: Brijesh Singh , x86 , LKML , kvm list , linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH Part2 v5 32/45] KVM: x86: Define RMP page fault error bits for #NPF Message-ID: References: <20210820155918.7518-1-brijesh.singh@amd.com> <20210820155918.7518-33-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Sep 30, 2021 at 04:41:54PM -0700, Marc Orr wrote: > On Fri, Aug 20, 2021 at 9:00 AM Brijesh Singh wrote: > > > > When SEV-SNP is enabled globally, the hardware places restrictions on all > > memory accesses based on the RMP entry, whether the hypervisor or a VM, > > performs the accesses. When hardware encounters an RMP access violation > > during a guest access, it will cause a #VMEXIT(NPF). > > > > See APM2 section 16.36.10 for more details. > > nit: Section # should be 15.36.10 (rather than 16.36.10). Also, is it > better to put section headings, rather than numbers in the commit logs > and comments? Someone mentioned to me that the section numbering in > APM and SDM can move around over time, but the section titles tend to > be more stable. I'm not sure how true this is, so feel free to > disregard this comment. No, that comment is correct, please make it unambiguous so that if someone's looking later, someone can find the section even in future docs. (I'm hoping they don't change headings, that is...). -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette