From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7118C433EF for ; Wed, 13 Oct 2021 22:10:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAC34610FE for ; Wed, 13 Oct 2021 22:10:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231235AbhJMWMh (ORCPT ); Wed, 13 Oct 2021 18:12:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231293AbhJMWMf (ORCPT ); Wed, 13 Oct 2021 18:12:35 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FBE6C06174E for ; Wed, 13 Oct 2021 15:10:32 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id c29so3729557pfp.2 for ; Wed, 13 Oct 2021 15:10:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ueFCf5T8Bg/YvAT2Irg4dCLqPcpMWw3L37AGd4LH77U=; b=ddB5dJguEn3AgeR8395if1R9x3C4WiiCEHEcLvuAwFd69ToBSZMQrYK0rFuAgGH7jj LxbackalERaHCzi17YPTTva5EdkoIy7y9odkfcQr2WlqoErVDYKZBlYyO0aBnL6OPstJ ECTcb3yW3fVsFehOqRy1jlToBYF4XsvOcOhE2jCsUPTkarAINfPRKHvfSmMdK4ZnKrlj f/0ju2P1R77N0Wra6jhyEzuEXawq+KKPUyUMT0wAzYCRoW4LkNETvrEJnSKmWjTIPdMM 4pKa0/D2MvpqkkbL4VgY8slUh+VCAla+m5bvZXO9ZQV6N4/IRLRTTWPs3Ml170oSPN2z RFGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ueFCf5T8Bg/YvAT2Irg4dCLqPcpMWw3L37AGd4LH77U=; b=ifAD3VWGAOkLtB1S/IQPl7nOnHsdTGQ9O+gxkCpeG0mqYBfXQWPUBytiXwD7m5w9oE 6WFDwNljcwnu75JuFxyGNk4VPyZEht+nUz8QijsTkfvgjGoiwvYNe8ditZ26mZqgHz62 O7sbIcT/4efRLqkWjPRoZ+BNHuuOq/YBBWPdxO9Ww3HlCOswWzuKIqzp477uzvezaDDW vGturVkCxoVHj0zUw4mff5CLik5Uoy4juYHeGafh7QtItnwvC/S219DqsVyliW67lmhP FoLuJDJNSPkUDMhSEk37QJoZgZZE4YKXLtHldAaE8h47cIQITtMI48jdwu9pO3yqkxa5 M/tg== X-Gm-Message-State: AOAM5332MkQJkVmhTGCZKKV7MB9u+KySHyIGsFRyh7iu2bTk86ta2Jui JCekB37UajpTYYQlLDWgZJkSlQ== X-Google-Smtp-Source: ABdhPJyOsn/Qy+slP5sYwji6knnMfIk70CbncfyHR8vuoYubpw8pbf8X2wfltlhjNumK/GzkJzAi7Q== X-Received: by 2002:a62:3102:0:b0:44b:63db:fc88 with SMTP id x2-20020a623102000000b0044b63dbfc88mr1856516pfx.75.1634163031545; Wed, 13 Oct 2021 15:10:31 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id z68sm445168pgz.90.2021.10.13.15.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 15:10:30 -0700 (PDT) Date: Wed, 13 Oct 2021 22:10:26 +0000 From: Sean Christopherson To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH Part2 v5 39/45] KVM: SVM: Introduce ops for the post gfn map and unmap Message-ID: References: <20210820155918.7518-1-brijesh.singh@amd.com> <20210820155918.7518-40-brijesh.singh@amd.com> <94128da2-c9f7-d990-2508-5a56f6cf16e7@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Oct 13, 2021, Brijesh Singh wrote: > > On 10/13/21 1:10 PM, Sean Christopherson wrote: > > Side topic, what do you think about s/assigned/private for the "public" APIs, as > > suggested/implied above? I actually like the terminology when talking specifically > > about the RMP, but it doesn't fit the abstractions that tend to be used when talking > > about these things in other contexts, e.g. in KVM. > > I can float the idea to see if docs folks is okay with the changes but > generally speaking we all have been referring the assigned == private in > the Linux SNP support patch. Oh, I wasn't suggesting anything remotely close to an "official" change, it was purely a suggestion for the host-side patches. It might even be unique to this one helper.