From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A78DC433F5 for ; Tue, 26 Oct 2021 08:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5135560E75 for ; Tue, 26 Oct 2021 08:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234304AbhJZInM (ORCPT ); Tue, 26 Oct 2021 04:43:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34817 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234299AbhJZInF (ORCPT ); Tue, 26 Oct 2021 04:43:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635237640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xfjmzkgFWA1L7jlAQ35kT9YQRKqeL4m1Zaudd45fWoU=; b=ShYDxjJoAL0zHPJIsgxBqRRUU9KBSnaUelwjo5igSvjC7u1vGPTA839Mf0Vj0QuuuArrxM nEbeLlWQylYMhCRW/NyQ7apSZnEVC+ME225nnTa3G/u4PJ/nqIU3XfEaD710RxJmOoalnF HI42iDZ0vgaf19jm+LozJvu7GXwLB98= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-AdSssY3fM_-VnSwCuxrgEQ-1; Tue, 26 Oct 2021 04:40:38 -0400 X-MC-Unique: AdSssY3fM_-VnSwCuxrgEQ-1 Received: by mail-wr1-f69.google.com with SMTP id v15-20020adfa1cf000000b00160940b17a2so3757228wrv.19 for ; Tue, 26 Oct 2021 01:40:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xfjmzkgFWA1L7jlAQ35kT9YQRKqeL4m1Zaudd45fWoU=; b=QXnq+0crXDU4RocZ7sJFme8eliz0/reOhA+HWIi66aUrKUql4fWMQ84+nEu2pHRPRZ wEF6u2Vk5snwhffM/A8mu4EOFM7/LE3HkCiyyA6+jtYEkgmY9zpAB2ufawwjQChWStDl FWH6HBK7JS8IveC4ZpZ4PaMfDObv0h4O9IveOn6v1H0MKvXfXjfsSCbsDde5n+RTPsIo dqA+UZTVUOvQ1TmJbTqolD6MFqJeyUwNn6AgCad9ejqoImdFvimafGU01KUikK44uLTn 3F/rZBshQG01ok5yKGVrbfHglABHQMZyiec3uU5DyzBsFIUE7YKOkOzzTI6Vlw6yR/qI YOOQ== X-Gm-Message-State: AOAM530TvLyXdVJUT13DqcXnhFeuVdvQjY9RvlMOf50usoMWiDrfVeyo zJYR7qW/w2FMZ9djYuioj8p7ICufB8TDjpPuo6h1vAFf2gopxvzVOCtcWORqI0LPbHBC1/84bML Bs+uUoGMrmwkg X-Received: by 2002:a5d:6c61:: with SMTP id r1mr17547139wrz.54.1635237637592; Tue, 26 Oct 2021 01:40:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5GdEzMaju+58GxCQgRDsiOrRrD/jJb7jUfrLgVL9mXDAbPVNJiHhiKtV/0v4Tq6aEaUO8Rg== X-Received: by 2002:a5d:6c61:: with SMTP id r1mr17547112wrz.54.1635237637425; Tue, 26 Oct 2021 01:40:37 -0700 (PDT) Received: from work-vm (cpc109025-salf6-2-0-cust480.10-2.cable.virginm.net. [82.30.61.225]) by smtp.gmail.com with ESMTPSA id d1sm18850117wrr.72.2021.10.26.01.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 01:40:36 -0700 (PDT) Date: Tue, 26 Oct 2021 09:40:34 +0100 From: "Dr. David Alan Gilbert" To: Jason Gunthorpe Cc: Alex Williamson , Yishai Hadas , bhelgaas@google.com, saeedm@nvidia.com, linux-pci@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, kuba@kernel.org, leonro@nvidia.com, kwankhede@nvidia.com, mgurtovoy@nvidia.com, maorg@nvidia.com, Cornelia Huck Subject: Re: [PATCH V2 mlx5-next 12/14] vfio/mlx5: Implement vfio_pci driver for mlx5 devices Message-ID: References: <20211019124352.74c3b6ba.alex.williamson@redhat.com> <20211019192328.GZ2744544@nvidia.com> <20211019145856.2fa7f7c8.alex.williamson@redhat.com> <20211019230431.GA2744544@nvidia.com> <5a496713-ae1d-11f2-1260-e4c1956e1eda@nvidia.com> <20211020105230.524e2149.alex.williamson@redhat.com> <20211025115535.49978053.alex.williamson@redhat.com> <20211025191509.GB2744544@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211025191509.GB2744544@nvidia.com> User-Agent: Mutt/2.0.7 (2021-05-04) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org * Jason Gunthorpe (jgg@nvidia.com) wrote: > On Mon, Oct 25, 2021 at 07:47:29PM +0100, Dr. David Alan Gilbert wrote: > > > It may need some further refinement; for example in that quiesed state > > do counters still tick? will a NIC still respond to packets that don't > > get forwarded to the host? > > At least for the mlx5 NIC the two states are 'able to issue outbound > DMA' and 'all internal memories and state are frozen and unchanging'. Yeh, so my point was just that if you're adding a new state to this process, you need to define the details like that. Dave > The later means it should not respond/count/etc to network packets > either. > > Roughly it is > 'able to mutate external state' / 'able to mutate internal state' > > The invariant should be that successive calls to serialize the > internal state while frozen should return the same serialization. > > We may find that migratable PCI functions must have some limited > functionality. Ie anything with a realtime compoment - for instance a > sync-ethernet clock synchronization control loop, may become > challenging to migrate without creating a serious functional > distortion. > > Jason > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK