From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3517C433EF for ; Wed, 12 Jan 2022 17:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355568AbiALRVk (ORCPT ); Wed, 12 Jan 2022 12:21:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355567AbiALRVb (ORCPT ); Wed, 12 Jan 2022 12:21:31 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABC2BC061751 for ; Wed, 12 Jan 2022 09:21:30 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id l16-20020a17090a409000b001b2e9628c9cso6087737pjg.4 for ; Wed, 12 Jan 2022 09:21:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TYHRM7+kADwOp9diBRrPGp4L0N1LoYL1IUvHa0nGaUc=; b=UOi9kIvtR/IrJwzo5niwxDtXudsV6IxInf5Xux8zgZWocQk2IEmaYc0XSVBraMOzip 1p6oktTDeAT0Xo0Y1Hv38DXQkmSLxGT3a21Lcwuzm9HPptZ8CwyjAsbDUolqExCQJBvI 3/Ilf2Jr3LSRwS8m0x3JSZhofT299fDyux/e4JRm1BTZb8xRszyzcX2IlMX1MSEgYjMT 4xhdcYSj8HE0lJizFcqyvQ1F0sIsor9GOdwCIFkIY/f5YjDSO/UpiSWU7FnrM6Aap0Ov XAwRUtuXNr7yYBD4h8SO2lxl+txc3ZtlyhAeUA7I20RlONuBzpovIUUx1rYk6w6DmC66 icRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TYHRM7+kADwOp9diBRrPGp4L0N1LoYL1IUvHa0nGaUc=; b=VMAgHn2cBz8qCylaAB1Jezn3+lFm7PLJdl3MuSr4rCSgNDFgNFcflRRoV7f4t8EMum yRldhkMEei+JT2jOt7n7NO62OtXgjMzwnorBorSgURX7CKPEa2pcqQnoUs7GO2dw00T2 ZIpaEYHakmIhGhBr4td/EouZpxx06YkXlbkBJ0qGzL93x1BfZlpVLMu3zDC8uGK7aYaI 6DjGP7lP5h8IHCOwqwa8tZkN+YSkhFQSFGjc4VUX8J+d44fOBqVoqez+IE83gXrZSKO0 FyU7VguBb8OCDvtAmyU1gnzSDroTyJJboJHO5SQOclp5pFlNF5/RUTVe0hr69FdjykPX 9Phw== X-Gm-Message-State: AOAM5335RckBF8HVL16DLClTeCi2LUwhg/f6YKRFX4kC3oEYozENLjW8 eiCM34jtnYWjT5xN0/GgH3XJqw== X-Google-Smtp-Source: ABdhPJzFOOljTybPaAkOSjlPQwykizLUTnzjLoFkEgLqIZkrqe/Ahlwi51dGj1hKKqsANfiIKGdNKw== X-Received: by 2002:a63:7845:: with SMTP id t66mr576433pgc.103.1642008090029; Wed, 12 Jan 2022 09:21:30 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id qe10sm7011428pjb.5.2022.01.12.09.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 09:21:29 -0800 (PST) Date: Wed, 12 Jan 2022 17:21:25 +0000 From: Sean Christopherson To: Chao Gao Cc: kvm@vger.kernel.org, pbonzini@redhat.com, kevin.tian@intel.com, tglx@linutronix.de, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , David Hildenbrand , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , "Maciej S. Szmigiero" , Fabiano Rosas , Ravi Bangoria , =?iso-8859-1?Q?C=E9dric?= Le Goater , Bharata B Rao , Nicholas Piggin , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 3/6] KVM: Remove opaque from kvm_arch_check_processor_compat Message-ID: References: <20211227081515.2088920-1-chao.gao@intel.com> <20211227081515.2088920-4-chao.gao@intel.com> <20220111031933.GB2175@gao-cwp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jan 12, 2022, Sean Christopherson wrote: > On Tue, Jan 11, 2022, Chao Gao wrote: > > On Mon, Jan 10, 2022 at 11:06:44PM +0000, Sean Christopherson wrote: > > >On Mon, Dec 27, 2021, Chao Gao wrote: > > >> No arch implementation uses this opaque now. > > > > > >Except for the RISC-V part, this can be a pure revert of commit b99040853738 ("KVM: > > >Pass kvm_init()'s opaque param to additional arch funcs"). I think it makes sense > > >to process it as a revert, with a short blurb in the changelog to note that RISC-V > > >is manually modified as RISC-V support came along in the interim. > > > > commit b99040853738 adds opaque param to kvm_arch_hardware_setup(), which isn't > > reverted in this patch. I.e., this patch is a partial revert of b99040853738 > > plus manual changes to RISC-V. Given that, "process it as a revert" means > > clearly say in changelog that this commit contains a partial revert of commit > > b99040853738 ("KVM: Pass kvm_init()'s opaque param to additional arch funcs"). > > > > Right? > > What I meant is literally do > > git revert -s b99040853738 > > and then manually handle RISC-V. Doh, to be clear, "manually handle RISC-V _in the same commit_".