From: Sean Christopherson <seanjc@google.com>
To: Zeng Guang <guang.zeng@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Luck, Tony" <tony.luck@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Kim Phillips <kim.phillips@amd.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jethro Beekman <jethro@fortanix.com>,
"Huang, Kai" <kai.huang@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Hu, Robert" <robert.hu@intel.com>,
"Gao, Chao" <chao.gao@intel.com>
Subject: Re: [PATCH v5 8/8] KVM: VMX: Resize PID-ponter table on demand for IPI virtualization
Date: Thu, 20 Jan 2022 01:01:43 +0000 [thread overview]
Message-ID: <Yei0d0KVnNphPrP3@google.com> (raw)
In-Reply-To: <aba84be5-562a-369e-913d-1b834c141cc6@intel.com>
On Wed, Jan 19, 2022, Zeng Guang wrote:
> It's self-adaptive , standalone function module in kvm, no any extra
> limitation introduced
I disagree. Its failure mode on OOM is to degrade guest performance, _that_ is
a limitation. OOM is absolutely something that should be immediately communicated
to userspace in a way that userspace can take action.
> and scalable even future extension on KVM_MAX_VCPU_IDS or new apic id
> implementation released.
>
> How do you think ? :)
Heh, I think I've made it quite clear that I think it's unnecesary complexity in
KVM. It's not a hill I'll die on, e.g. if Paolo and others feel it's the right
approach then so be it, but I really, really dislike the idea of dynamically
changing the table, KVM has a long and sordid history of botching those types
of flows/features.
next prev parent reply other threads:[~2022-01-20 1:01 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 14:28 [PATCH v5 0/8] IPI virtualization support for VM Zeng Guang
2021-12-31 14:28 ` [PATCH v5 1/8] x86/cpu: Add new VMX feature, Tertiary VM-Execution control Zeng Guang
2021-12-31 14:28 ` [PATCH v5 2/8] KVM: VMX: Extend BUILD_CONTROLS_SHADOW macro to support 64-bit variation Zeng Guang
2021-12-31 14:28 ` [PATCH v5 3/8] KVM: VMX: Detect Tertiary VM-Execution control when setup VMCS config Zeng Guang
2021-12-31 14:28 ` [PATCH v5 4/8] KVM: VMX: dump_vmcs() reports tertiary_exec_control field as well Zeng Guang
2022-01-13 21:03 ` Sean Christopherson
2022-01-14 4:19 ` Zeng Guang
2022-01-20 1:06 ` Sean Christopherson
2022-01-20 5:34 ` Zeng Guang
2021-12-31 14:28 ` [PATCH v5 5/8] KVM: x86: Support interrupt dispatch in x2APIC mode with APIC-write VM exit Zeng Guang
2022-01-13 21:29 ` Sean Christopherson
2022-01-14 7:52 ` Zeng Guang
2022-01-14 17:34 ` Sean Christopherson
2022-01-15 2:08 ` Zeng Guang
2022-01-18 0:44 ` Yuan Yao
2022-01-18 3:06 ` Zeng Guang
2022-01-18 18:17 ` Sean Christopherson
2022-01-19 2:48 ` Zeng Guang
2021-12-31 14:28 ` [PATCH v5 6/8] KVM: VMX: enable IPI virtualization Zeng Guang
2022-01-13 21:47 ` Sean Christopherson
2022-01-14 5:36 ` Zeng Guang
2021-12-31 14:28 ` [PATCH v5 7/8] KVM: VMX: Update PID-pointer table entry when APIC ID is changed Zeng Guang
2022-01-05 19:13 ` Tom Lendacky
2022-01-06 1:44 ` Zeng Guang
2022-01-06 14:06 ` Tom Lendacky
2022-01-07 8:05 ` Zeng Guang
2022-01-07 8:31 ` Maxim Levitsky
2022-01-10 7:45 ` Chao Gao
2022-01-10 22:24 ` Maxim Levitsky
2022-01-13 22:19 ` Sean Christopherson
2022-01-14 2:58 ` Chao Gao
2022-01-14 8:17 ` Maxim Levitsky
2022-01-17 3:17 ` Chao Gao
2022-02-02 23:23 ` Sean Christopherson
2022-02-03 20:22 ` Sean Christopherson
2022-02-23 6:10 ` Chao Gao
2022-02-23 10:26 ` Maxim Levitsky
2022-01-14 0:22 ` Yuan Yao
2021-12-31 14:28 ` [PATCH v5 8/8] KVM: VMX: Resize PID-ponter table on demand for IPI virtualization Zeng Guang
2022-01-13 22:09 ` Sean Christopherson
2022-01-14 15:59 ` Zeng Guang
2022-01-14 16:18 ` Sean Christopherson
2022-01-17 15:04 ` Zeng Guang
2022-01-18 17:15 ` Sean Christopherson
2022-01-19 7:55 ` Zeng Guang
2022-01-20 1:01 ` Sean Christopherson [this message]
2022-01-24 16:40 ` Zeng Guang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yei0d0KVnNphPrP3@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=guang.zeng@intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=jethro@fortanix.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=kim.phillips@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=robert.hu@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).