From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E95D3C433EF for ; Mon, 31 Jan 2022 13:59:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359353AbiAaN77 (ORCPT ); Mon, 31 Jan 2022 08:59:59 -0500 Received: from mail.skyhub.de ([5.9.137.197]:41116 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348918AbiAaN75 (ORCPT ); Mon, 31 Jan 2022 08:59:57 -0500 Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B1C931EC0347; Mon, 31 Jan 2022 14:59:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1643637591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=OiqGrPMnbQIGw2+zC+4XudA/cLM9mrsP0jF/0Bd4QuQ=; b=B1bfoGuvGOFIzbVcNaBP0Z+si2wluMNhvOWIaHfam12kzi8OhDQJzZzYFskxalWY3v/4qM 9Qo7hkumcoibiHxtCvVrlvKKDUEQxhWIx/KwrVoGGy7ZSSCr/1g1jtlzZAzV5ZptuacS1F nGg+nK3P5+PoYvWU2nuxS3TDH2dVBeM= Date: Mon, 31 Jan 2022 14:59:48 +0100 From: Borislav Petkov To: David Woodhouse Cc: Tom Lendacky , Thomas Gleixner , Sean Christopherson , Ingo Molnar , Dave Hansen , "x86@kernel.org" , "H . Peter Anvin" , Paolo Bonzini , "Paul E . McKenney" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "rcu@vger.kernel.org" , "mimoja@mimoja.de" , "hewenliang4@huawei.com" , "hushiyuan@huawei.com" , "luolongjun@huawei.com" , "hejingxian@huawei.com" , Joerg Roedel , Andrew Cooper Subject: Re: [PATCH v3 6/9] x86/smpboot: Support parallel startup of secondary CPUs Message-ID: References: <20211215145633.5238-1-dwmw2@infradead.org> <20211215145633.5238-7-dwmw2@infradead.org> <3d8e2d0d-1830-48fb-bc2d-995099f39ef0@amd.com> <330bedfee12022c1180d8752fb4abe908dac08d1.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <330bedfee12022c1180d8752fb4abe908dac08d1.camel@infradead.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sat, Jan 29, 2022 at 12:04:19PM +0000, David Woodhouse wrote: > I've rebased and pushed to > https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/parallel-5.17 > > I'll do some more testing and repost the series during next week. The > win is slightly more modest than the original patch sets because it now > only parallelises x86/cpu:kick. I'm going to do more careful review and > testing before doing the same for x86/cpu:wait-init in a later series. > You can see that coming together in the git tree but I'm only going to > post up to the 'Serialise topology updates' patch again for now. Btw, Mr. Cooper points out a very important aspect and I don't know whether you've verified this already or whether this is not affected by your series ... yet. In any case it should be checked: microcode loading. See __reload_late() and all that dance we do to keep SMT siblings do nothing at the same time while updating microcode. With the current boot order, the APs should all do nothing so they won't need that sync for early loading - load_ucode_{ap,bsp} - but I don't know if you're changing that order with the parallel startup. If you do, you'll probably need such syncing for the early loading too... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette