From: Nicolin Chen <nicolinc@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: <joro@8bytes.org>, <will@kernel.org>, <marcan@marcan.st>,
<sven@svenpeter.dev>, <robin.murphy@arm.com>,
<robdclark@gmail.com>, <matthias.bgg@gmail.com>,
<orsonzhai@gmail.com>, <baolin.wang7@gmail.com>,
<zhang.lyra@gmail.com>, <jean-philippe@linaro.org>,
<alex.williamson@redhat.com>, <jgg@nvidia.com>,
<kevin.tian@intel.com>, <suravee.suthikulpanit@amd.com>,
<alyssa@rosenzweig.io>, <dwmw2@infradead.org>,
<yong.wu@mediatek.com>, <mjrosato@linux.ibm.com>,
<gerald.schaefer@linux.ibm.com>, <thierry.reding@gmail.com>,
<vdumpa@nvidia.com>, <jonathanh@nvidia.com>, <cohuck@redhat.com>,
<thunder.leizhen@huawei.com>, <tglx@linutronix.de>,
<christophe.jaillet@wanadoo.fr>, <john.garry@huawei.com>,
<chenxiang66@hisilicon.com>, <saiprakash.ranjan@codeaurora.org>,
<isaacm@codeaurora.org>, <yangyingliang@huawei.com>,
<jordan@cosmicpenguin.net>, <iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-s390@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>,
<kvm@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group
Date: Wed, 15 Jun 2022 19:40:02 -0700 [thread overview]
Message-ID: <YqqYAtfn7PQeCxgW@Asurada-Nvidia> (raw)
In-Reply-To: <0c0e6ec8-725d-93e8-44f1-db6c8a673a97@linux.intel.com>
On Thu, Jun 16, 2022 at 10:09:49AM +0800, Baolu Lu wrote:
> External email: Use caution opening links or attachments
>
>
> On 2022/6/16 08:03, Nicolin Chen wrote:
> > diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> > index 44016594831d..0dd13330fe12 100644
> > --- a/drivers/iommu/intel/iommu.c
> > +++ b/drivers/iommu/intel/iommu.c
> > @@ -4323,7 +4323,7 @@ static int prepare_domain_attach_device(struct iommu_domain *domain,
> > return -ENODEV;
> >
> > if (dmar_domain->force_snooping && !ecap_sc_support(iommu->ecap))
> > - return -EOPNOTSUPP;
> > + return -EMEDIUMTYPE;
> >
> > /* check if this iommu agaw is sufficient for max mapped address */
> > addr_width = agaw_to_width(iommu->agaw);
> > @@ -4331,10 +4331,10 @@ static int prepare_domain_attach_device(struct iommu_domain *domain,
> > addr_width = cap_mgaw(iommu->cap);
> >
> > if (dmar_domain->max_addr > (1LL << addr_width)) {
> > - dev_err(dev, "%s: iommu width (%d) is not "
> > + dev_dbg(dev, "%s: iommu width (%d) is not "
> > "sufficient for the mapped address (%llx)\n",
> > __func__, addr_width, dmar_domain->max_addr);
> > - return -EFAULT;
> > + return -EMEDIUMTYPE;
> > }
> > dmar_domain->gaw = addr_width;
>
> Can we simply remove the dev_err()? As the return value has explicitly
> explained the failure reason, putting a print statement won't help much.
Yes. As long as no one has objection, I can remove that in the next
version.
next prev parent reply other threads:[~2022-06-16 2:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 0:02 [PATCH v2 0/5] Simplify vfio_iommu_type1 attach/detach routine Nicolin Chen
2022-06-16 0:03 ` [PATCH v2 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Nicolin Chen
2022-06-16 2:09 ` Baolu Lu
2022-06-16 2:40 ` Nicolin Chen [this message]
2022-06-16 6:28 ` Tian, Kevin
2022-06-16 0:03 ` [PATCH v2 2/5] vfio/iommu_type1: Prefer to reuse domains vs match enforced cache coherency Nicolin Chen
2022-06-16 6:29 ` Tian, Kevin
2022-06-21 22:46 ` Alex Williamson
2022-06-21 23:47 ` Nicolin Chen
2022-06-16 0:03 ` [PATCH v2 3/5] vfio/iommu_type1: Remove the domain->ops comparison Nicolin Chen
2022-06-16 6:40 ` Tian, Kevin
2022-06-16 22:23 ` Nicolin Chen
2022-06-22 7:54 ` Robin Murphy
2022-06-23 3:50 ` Tian, Kevin
2022-06-23 7:47 ` Nicolin Chen
2022-06-24 13:16 ` Jason Gunthorpe
2022-06-24 18:31 ` Robin Murphy
2022-06-24 18:46 ` Jason Gunthorpe
2022-06-16 0:03 ` [PATCH v2 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group() Nicolin Chen
2022-06-16 6:45 ` Tian, Kevin
2022-06-16 22:26 ` Nicolin Chen
2022-06-16 0:03 ` [PATCH v2 5/5] vfio/iommu_type1: Simplify group attachment Nicolin Chen
2022-06-16 7:08 ` Tian, Kevin
2022-06-16 22:40 ` Nicolin Chen
2022-06-17 2:53 ` Tian, Kevin
2022-06-17 23:07 ` Nicolin Chen
2022-06-20 4:03 ` Jason Gunthorpe
2022-06-21 20:59 ` Nicolin Chen
2022-06-20 10:11 ` Robin Murphy
2022-06-21 21:08 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqqYAtfn7PQeCxgW@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alyssa@rosenzweig.io \
--cc=baolin.wang7@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=john.garry@huawei.com \
--cc=jonathanh@nvidia.com \
--cc=jordan@cosmicpenguin.net \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=matthias.bgg@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=orsonzhai@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@svenpeter.dev \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=vdumpa@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yangyingliang@huawei.com \
--cc=yong.wu@mediatek.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).