From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3413ECAAA1 for ; Fri, 16 Sep 2022 17:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229553AbiIPR1R (ORCPT ); Fri, 16 Sep 2022 13:27:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbiIPR1Q (ORCPT ); Fri, 16 Sep 2022 13:27:16 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91234B5A70 for ; Fri, 16 Sep 2022 10:27:15 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id p1-20020a17090a2d8100b0020040a3f75eso287682pjd.4 for ; Fri, 16 Sep 2022 10:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=UyWqRe5MVdeXCpVzDr2ABned/JszdfyREGM9jJ5sQrM=; b=ZR5nmoavwk+87rfzPPmsyfUvVkz76glpVzTHcbNP/gbz5LaNphzPaS1ucnPcqhlQGf Wcxt76Hgq3h/uiwiQg7C/2Jgs8ynqrqzLk33VzUBnyGdblJtS+icXJZMJc12ghzRk1tD n2wNOHHibFFQMaOUn/j2NXvfDR++XI8ruo1f6XYbujd0Lag0p3LjYKzhwse4AkixFMqP +EYk0ILyrpwdH6aYdca1QSQ6QD7u1x2sXV57cydgKVaKOEtd6FzBiJJSGUtfjUsRlMh+ C+xV4ZtdHUt2JwapV7nY9jR2zg2PtsnIAOj4Hn+NjlzxOCW3Kn8hIFId7pOFOnl+RllX 6biQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=UyWqRe5MVdeXCpVzDr2ABned/JszdfyREGM9jJ5sQrM=; b=QUc3SOlxopUhkh635FP9bGJw3Nrf6kueuUmQ5w8pR1rJqn7wx0tijg980AtNPskkyF O2KAA4NDJDXuqwVVfYH7QJK2hGCDYPyn9SjFoNmhwhafmrKzPaTBf1Z9EEkEme00qxmn trKQ8q0lubOuzoylhxoUOFWmmtGlduEh3vO+LJyGRnbnPbh9AOkKnhphvbI+vPoSrlZk v+4O8NZNlFbnU7t94wM6FfqSzd0E9TCnyKyaq8lXbrmCcrMKXHjxq3EWWaFJJ2pFXFuZ c954+jwz7Uib+541uIyx+ulIi/sLcw3O4P2pJM6yodzkLgD4hq719YZygFyfgGVlF0H1 Yg7w== X-Gm-Message-State: ACrzQf2OyCl/6NhK21ps5bLCLnphh9tHPzf5zN3Sxy1lRmAZAyeqoxlz 6mNuHDaQMXOwIHgg77gNOyrXKQ== X-Google-Smtp-Source: AMsMyM7FK0LXPA3SPb/96N6U1OwN6w17UHL/7MrTYQAL9sj9KQm1ME3k4S7AmREnC7XfL/KrECveuQ== X-Received: by 2002:a17:902:b18e:b0:178:3484:f45e with SMTP id s14-20020a170902b18e00b001783484f45emr866965plr.166.1663349234923; Fri, 16 Sep 2022 10:27:14 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id w4-20020a170902e88400b0017682b90532sm15177810plg.194.2022.09.16.10.27.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 10:27:14 -0700 (PDT) Date: Fri, 16 Sep 2022 17:27:10 +0000 From: Sean Christopherson To: liujing Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: duplicate code Message-ID: References: <20220916032656.6264-1-liujing@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220916032656.6264-1-liujing@cmss.chinamobile.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org "KVM: x86/mmu:" for the scope. And explicitly state what the patch does, not what the symptom is, especially since "duplicate" can be an adjective, noun, or a verb depending on context. And as an almost nit, state that it's a comment so that it's obvious from the shortlog that the patch should have no functional impact. On Thu, Sep 15, 2022, liujing wrote: > in "static int FNAME(walk_addr_generic)" function, > there is an explanation that uses two to's, which is redundant code Again, explicitly state what the patch actually does. All that said, a patch has already been submitted for this[*]. No need to send a v2, I'll grab the previous patch. Thanks! [*] https://lore.kernel.org/all/20220831125217.12313-1-yuanjilin@cdjrlc.com