From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552A4C6FA8E for ; Wed, 21 Sep 2022 14:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbiIUOdG (ORCPT ); Wed, 21 Sep 2022 10:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229578AbiIUOdC (ORCPT ); Wed, 21 Sep 2022 10:33:02 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E9BD1176 for ; Wed, 21 Sep 2022 07:33:01 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id q9so6108007pgq.8 for ; Wed, 21 Sep 2022 07:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=TXX2kEYvP+keRhbXIQlLBE8g6in+6NE/OdqG2arPwcQ=; b=MVUX+DY8Drl/QkKSc5ik7I/HVpcLaN6bNdGTiLOx29pNGXl3j3QktzEY9wY4J+K/DX vuzON9X+2TZ6BJD87LwDBcUkXYSO94kYJJ/5yYxNNVEoL9xiRqrQt/HvsjfbO3SZH+Cn FVKo8Kj4pmMREeVAcjzK0xORYjk4JXyfmVhtWKHHsC/j9IzYumj5reHFZWXpmSs++c4m 84dnkQmUZhz19T1UatvP5QwKjCXF2NZg+oo7nnw1YOej4yN8N0TFX1VyPBcS6pW/076y ZwhccIH2Mo2T/MGGyZCphjnrOVSDKl8W8DHykZ8AgZtBVwqQ9LZ/hID3/BvfQegiveYQ XlUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=TXX2kEYvP+keRhbXIQlLBE8g6in+6NE/OdqG2arPwcQ=; b=49cqIWdSN5OONBF4jIBu2eMpiE4dddcqQwzIqld72odZTH4Nnc8CsBIOjDqMDvnY82 ot6KH8lSH9yZN5VoRHlP2Jfsi63qdIqpcUM39aad8Hl+U5RwjNHtwYck5FcRRXI5swB8 CpPClO4HSwMIRKBucjUA7Pbb2Kp/lwXcVLbgvcwMRP5Qvn5IyB3OfrfRYep91ZPvnLXH KbUjj0gcdf4xaSQOqPS355JkeA/8zK60gWnhhaIKfyYiCJEhOziFah9491NR7CAcyR3C QZ+AhMT/6qnSGKbr7DLptT8dvf3Bupw9FPwgW2mWLqRifUV/W1Qe0O7nyNPb46ujJK1j 7vZg== X-Gm-Message-State: ACrzQf11zTDHMM6vLyb5C3qBu9qoTQVJOTPmZg96Fb0Zcgc8B38exaM2 MZfuoVZrTZ0+Ou4UffEMlCgV1A== X-Google-Smtp-Source: AMsMyM5bkHpte9sxPJF9TD4rLdpx62EGBicjptAbuNtHBB1FwmoNBbypoRde9PMErtKckon+2kpyIg== X-Received: by 2002:a63:778d:0:b0:438:5c5b:f2ac with SMTP id s135-20020a63778d000000b004385c5bf2acmr24975144pgc.401.1663770780693; Wed, 21 Sep 2022 07:33:00 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id e2-20020a63f542000000b0043a09d5c32bsm1908021pgk.74.2022.09.21.07.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 07:33:00 -0700 (PDT) Date: Wed, 21 Sep 2022 14:32:44 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Michael Kelley , Maxim Levitsky , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/6] KVM: x86: Hyper-V invariant TSC control Message-ID: References: <20220916135205.3185973-1-vkuznets@redhat.com> <20220916135205.3185973-4-vkuznets@redhat.com> <87zgetnnf9.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zgetnnf9.fsf@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Sep 21, 2022, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > It's still not obvious to me why KVM shouldn't do: > > > > if (!hv_vcpu) > > return false; > > > > return !(hv_vcpu->cpuid_cache.features_eax & HV_ACCESS_TSC_INVARIANT) || > > !(to_kvm_hv(vcpu->kvm)->hv_invtsc_control & HV_INVARIANT_TSC_EXPOSED); > > > > I.e. why is invariant TSC _not_ suppressed on Hyper-V by default? > > In case we switch to suppressing invtsc (CPUID.80000007H:EDX[8]) by > default, i.e. when HV_ACCESS_TSC_INVARIANT was not set in guest visible > CPUIDs, this is going to be a behavioral change for the already existing > configurations and we certainly don't want that. It was expirementally > proven that at least some Windows versions are perfectly happy when they > see invtsc without this PV feature so I don't see a need to break the > status quo. > > this is VMM's job, not KVM's. Gotcha. Can you add a comment to capture this? In particular, the part about it being KVM's responsibility iff the Hyper-V control is exposed to the guest. Hmm, and I think it makes to repackage the code so that the "is KVM responsible" check is separated from the "is the control enabled". E.g. /* * If Hyper-V's invariant TSC control is exposed to the guest, KVM is * responsible for suppressing the invariant TSC CPUID flag if the * Hyper-V control is not enabled. */ if (!hv_vcpu || !(hv_vcpu->cpuid_cache.features_eax & HV_ACCESS_TSC_INVARIANT)) return false; return !(to_kvm_hv(vcpu->kvm)->hv_invtsc_control & HV_INVARIANT_TSC_EXPOSED);