From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08053C433FE for ; Thu, 6 Oct 2022 17:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231406AbiJFRgG (ORCPT ); Thu, 6 Oct 2022 13:36:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230489AbiJFRgE (ORCPT ); Thu, 6 Oct 2022 13:36:04 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C4F8BBE05 for ; Thu, 6 Oct 2022 10:36:01 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id s206so2474178pgs.3 for ; Thu, 06 Oct 2022 10:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rbMGbiWLbZ6FnhZh1qaYHgBpBs3UH3NTOE+nUewVjAk=; b=sJHFqhoqOUNHBvPnr+m27XIxbVeg6ZTJOM+S+LzI90HY+NpwIF3qbiWbcJZk3gJwA7 gIgZpnY31BRqpcIJlWI14mMuvg/EjCac4FesF3WRi73NlEiqTF8oZhqhHCnBbxgLlh1l FQWDU0OT3ZxFELn0LsZr7A8U92wBrJ6ZX6kAo75YB2qeMPu8XqRJjsYnrJ4R4BUuVjpq nPU+tskRY6WN9vHT5/bm3v8s78hG2PVLqKx/rPRZMCzLZlGbiaTvkTQ0sf6x7wiKMOUG vT0AnqVBclKoUDKEPRRAyabqHIJKu9yjG6RsDhbu9bJZev/zSkyCCfk4aDb5TfInSJ6T Jo2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rbMGbiWLbZ6FnhZh1qaYHgBpBs3UH3NTOE+nUewVjAk=; b=jwVS0YbJgNUbuVoDIoIc0QrMe1cig86+gCHJEiDuy5BBGyzohHI9C/aai3PsOXQ6yI McjOm6SVzFjMQA04oueWQ5mJj5/IMCQNEEFYR311Nm8VpNMdZCPBQY39zebqLN40EMUT MtSR1gLLdmuQ4IvutBm6o1JhKh2hbTifIR2jVSLvbqDpEqwLuu6lmnJZJKRbTpZkBMwF tNBrNc27nO1Ej1IOF0KTa59VMdg+HjfxeJw1ulm/ObrkDnLGh6soc0N5EpeEeUozXf0y uEurGizgnnsEpm86CZnxnvxbzndca3MesphIyuCGB0I1MvnWo1HU3FO3HGSHHv/8VtOy veSQ== X-Gm-Message-State: ACrzQf0YUUs6wb22rGY+lRT0RyTUm/o7tJ0tLJs1Oz1h5M2zvVDM9Hy8 K0YJZQi2SSFyXE7Va7e1oRsaMw== X-Google-Smtp-Source: AMsMyM4Zvi84MhK8aD81L4AnUh43YBqYOPPS5pxZvSZicm45UYwmJZa5l5y0hAd252YQ2NaHw2tz1Q== X-Received: by 2002:a63:1e47:0:b0:43c:261f:f773 with SMTP id p7-20020a631e47000000b0043c261ff773mr830690pgm.1.1665077760789; Thu, 06 Oct 2022 10:36:00 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id j6-20020a170902c08600b00178af82a08dsm12628456pld.91.2022.10.06.10.35.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 10:35:59 -0700 (PDT) Date: Thu, 6 Oct 2022 17:35:55 +0000 From: Sean Christopherson To: Peter Gonda Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, marcorr@google.com, michael.roth@amd.com, thomas.lendacky@amd.com, joro@8bytes.org, mizhang@google.com, pbonzini@redhat.com, andrew.jones@linux.dev Subject: Re: [V4 1/8] KVM: selftests: move vm_phy_pages_alloc() earlier in file Message-ID: References: <20220829171021.701198-1-pgonda@google.com> <20220829171021.701198-2-pgonda@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220829171021.701198-2-pgonda@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Aug 29, 2022, Peter Gonda wrote: > From: Michael Roth > > Subsequent patches will break some of this code out into file-local > helper functions, which will be used by functions like vm_vaddr_alloc(), > which currently are defined earlier in the file, so a forward > declaration would be needed. > > Instead, move it earlier in the file, just above vm_vaddr_alloc() and > and friends, which are the main users. Meh, the wrappers are one-liners, why not keep this where it is, keep it exposed, and then make the wrappers "static inline".