From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1388C74A5B for ; Fri, 17 Mar 2023 22:51:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230001AbjCQWvU (ORCPT ); Fri, 17 Mar 2023 18:51:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjCQWvS (ORCPT ); Fri, 17 Mar 2023 18:51:18 -0400 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5082D2958 for ; Fri, 17 Mar 2023 15:51:17 -0700 (PDT) Received: by mail-pj1-x104a.google.com with SMTP id u22-20020a17090abb1600b0023f0575ebf0so4233795pjr.9 for ; Fri, 17 Mar 2023 15:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679093477; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4VE1iHzPcbBwBz+W0Z9mQD/JqfyWws+rYI7qgbnqJ24=; b=X76aa+88Lm0L9+nU2RY+oehLL+uZeQVHQ3lC33fRrcs4GJusd37CvBwg1npPcZuoaQ geREk9EiZdCWI05TYiItxbL4xwUD0KX4ewcUdMQxy6mozPkZZ9hdUB5ZX48FQcJHEIgE D406GoLPyRJ72qWqM0BvN0tFwhzqrdH5hMXwPMv4L3Ag0G0Db+OJcUvN7XaIEeNC0fqT nGimFLuSMn1Iy3Lkf/Yhppd3jHT/h9XrqhtKWczlD0dYnYyORTiqHdsqw+r7ZZX10edv IVQQzB1vyTsZOy44ltfKd3dH7zBB/8zfkdtZzPilYnqCIp9BGBKAv8vrcEBGxPbC+Rhr n89A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679093477; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4VE1iHzPcbBwBz+W0Z9mQD/JqfyWws+rYI7qgbnqJ24=; b=laKeAcxZGdrsY0jMbiV0IcQAjmbEug6y5J8Z2y2QztFrbTHVuSZFD4eNN3eL6X8IXp v7jiWsff1vAntS1nypO2w7zyAHQpV1Bk0/rhLCqDGTPEPA6UZ9EOr3qDr+rH/WMDzARi w18Pr1eRFfqXsN+jCAftF8ZyTtiOtkrTq3VPlY+xDsC6AxYOe319znD0rKknz572ltH3 HdY4gCtKvovNFJWrkAUhOQ+jBc6CJxVxv/jDzkA3pOhiXLzIwZdyp16M/EJsjjreC3xL OIkEpElI1khEitxrZ+uc17ichB47bL+96jKcNdfaoGoRft9ULR2LvAfFjugpRbikdJiL FZCw== X-Gm-Message-State: AO0yUKWRgM2mezKPdOLt1KOF/MwQVzAtceTKDC+ZlMIA9R8SZmHvFgSG SEG2m74WVl6A0xsaqQR0WPomSq2c/F8= X-Google-Smtp-Source: AK7set975D5NqLPdB4ZrC43vRYKFxW38+uf7o5sjFi/RTDild/JZiSzUxzFBE+SLKor52v495Stt9b2HaPI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:a0b:b0:23b:419d:8efe with SMTP id gg11-20020a17090b0a0b00b0023b419d8efemr2761563pjb.3.1679093477360; Fri, 17 Mar 2023 15:51:17 -0700 (PDT) Date: Fri, 17 Mar 2023 15:51:15 -0700 In-Reply-To: <20230211014626.3659152-8-vipinsh@google.com> Mime-Version: 1.0 References: <20230211014626.3659152-1-vipinsh@google.com> <20230211014626.3659152-8-vipinsh@google.com> Message-ID: Subject: Re: [Patch v3 7/7] KVM: x86/mmu: Merge all handle_changed_pte* functions. From: Sean Christopherson To: Vipin Sharma Cc: pbonzini@redhat.com, bgardon@google.com, dmatlack@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Feb 10, 2023, Vipin Sharma wrote: > @@ -1301,7 +1283,7 @@ bool kvm_tdp_mmu_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) > /* > * No need to handle the remote TLB flush under RCU protection, the > * target SPTE _must_ be a leaf SPTE, i.e. cannot result in freeing a > - * shadow page. See the WARN on pfn_changed in __handle_changed_spte(). > + * shadow page. See the WARN on pfn_changed in handle_changed_spte(). I was just starting to think you're an ok person, and then I find out you're a heretic that only puts a single space after periods. ;-)