From: Sean Christopherson <seanjc@google.com>
To: Vipin Sharma <vipinsh@google.com>
Cc: pbonzini@redhat.com, bgardon@google.com, dmatlack@google.com,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v3 0/7] Optimize clear dirty log
Date: Fri, 17 Mar 2023 15:57:35 -0700 [thread overview]
Message-ID: <ZBTwX5790zwl5721@google.com> (raw)
In-Reply-To: <20230211014626.3659152-1-vipinsh@google.com>
On Fri, Feb 10, 2023, Vipin Sharma wrote:
> This patch series has optimized control flow of clearing dirty log and
> improved its performance by ~40% (2% more than v2).
>
> It also got rid of many variants of the handle_changed_spte family of
> functions and converged logic to one handle_changed_spte() function. It
> also remove tdp_mmu_set_spte_no_[acc_track|dirty_log] and various
> booleans for controlling them.
>
> v3:
> - Tried to do better job at writing commit messages.
LOL, that's the spirit!
Did a cursory glance, looks good. I'll do a more thorough pass next week and get
it queued up if all goes well. No need for a v4 at this point, I'll fixup David's
various nits when applying. I'll also add a link in patch 2 to the discussion
about why we determined that bypassing __tdp_mmu_set_spte() is safe; that's critical
information that isn't captured in the changelog.
next prev parent reply other threads:[~2023-03-17 22:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 1:46 [Patch v3 0/7] Optimize clear dirty log Vipin Sharma
2023-02-11 1:46 ` [Patch v3 1/7] KVM: x86/mmu: Add a helper function to check if an SPTE needs atomic write Vipin Sharma
2023-02-11 1:46 ` [Patch v3 2/7] KVM: x86/mmu: Atomically clear SPTE dirty state in the clear-dirty-log flow Vipin Sharma
2023-02-15 21:12 ` David Matlack
2023-03-17 22:59 ` Sean Christopherson
2023-03-17 23:50 ` Vipin Sharma
2023-02-11 1:46 ` [Patch v3 3/7] KVM: x86/mmu: Remove "record_dirty_log" in __tdp_mmu_set_spte() Vipin Sharma
2023-02-15 21:10 ` David Matlack
2023-02-11 1:46 ` [Patch v3 4/7] KVM: x86/mmu: Optimize SPTE change for aging gfn range Vipin Sharma
2023-02-15 21:15 ` David Matlack
2023-03-21 0:51 ` Sean Christopherson
2023-02-11 1:46 ` [Patch v3 5/7] KVM: x86/mmu: Remove "record_acc_track" in __tdp_mmu_set_spte() Vipin Sharma
2023-02-22 19:31 ` David Matlack
2023-02-11 1:46 ` [Patch v3 6/7] KVM: x86/mmu: Remove handle_changed_spte_dirty_log() Vipin Sharma
2023-02-22 19:36 ` David Matlack
2023-02-11 1:46 ` [Patch v3 7/7] KVM: x86/mmu: Merge all handle_changed_pte* functions Vipin Sharma
2023-02-22 19:42 ` David Matlack
2023-03-17 22:51 ` Sean Christopherson
2023-03-17 23:48 ` Vipin Sharma
2023-03-17 22:57 ` Sean Christopherson [this message]
2023-03-17 23:51 ` [Patch v3 0/7] Optimize clear dirty log Vipin Sharma
2023-03-21 0:41 ` Sean Christopherson
2023-03-21 18:11 ` Vipin Sharma
2023-03-21 19:57 ` Sean Christopherson
2023-03-21 20:40 ` Sean Christopherson
2023-03-21 21:38 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBTwX5790zwl5721@google.com \
--to=seanjc@google.com \
--cc=bgardon@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).