From: Boqun Feng <boqun.feng@gmail.com>
To: rcu@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Waiman Long <longman@redhat.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Frederic Weisbecker <frederic@kernel.org>,
Neeraj Upadhyay <quic_neeraju@quicinc.com>,
Joel Fernandes <joel@joelfernandes.org>,
Shuah Khan <shuah@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, seanjc@google.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH rcu 7/7] rcutorture: Add srcu_lockdep.sh
Date: Mon, 20 Mar 2023 11:19:05 -0700 [thread overview]
Message-ID: <ZBijmdz2ucql+BSb@boqun-archlinux> (raw)
In-Reply-To: <20230317031339.10277-8-boqun.feng@gmail.com>
Hi Paul,
On Thu, Mar 16, 2023 at 08:13:39PM -0700, Boqun Feng wrote:
> From: "Paul E. McKenney" <paulmck@kernel.org>
>
> This commit adds an srcu_lockdep.sh script that checks whether lockdep
> correctly classifies SRCU-based, SRCU/mutex-based, and SRCU/rwsem-based
> deadlocks.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> [ boqun: Fix "RCUTORTURE" with "$RCUTORTURE" ]
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> ---
> .../selftests/rcutorture/bin/srcu_lockdep.sh | 73 +++++++++++++++++++
> 1 file changed, 73 insertions(+)
> create mode 100755 tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh
>
> diff --git a/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh b/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh
> new file mode 100755
> index 000000000000..961932754684
> --- /dev/null
> +++ b/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh
Could you provide the SPDX header and copyright bits for this newly
added file? For small changes I can do it myself, however this is about
licenses and copyright, so I need it from you, thanks!
Regards,
Boqun
> @@ -0,0 +1,73 @@
> +#!/bin/bash
> +#
> +# Run SRCU-lockdep tests and report any that fail to meet expectations.
> +
> +usage () {
> + echo "Usage: $scriptname optional arguments:"
> + echo " --datestamp string"
> + exit 1
> +}
> +
> +ds=`date +%Y.%m.%d-%H.%M.%S`-srcu_lockdep
> +scriptname="$0"
> +
> +T="`mktemp -d ${TMPDIR-/tmp}/srcu_lockdep.sh.XXXXXX`"
> +trap 'rm -rf $T' 0
> +
> +RCUTORTURE="`pwd`/tools/testing/selftests/rcutorture"; export RCUTORTURE
> +PATH=${RCUTORTURE}/bin:$PATH; export PATH
> +. functions.sh
> +
> +while test $# -gt 0
> +do
> + case "$1" in
> + --datestamp)
> + checkarg --datestamp "(relative pathname)" "$#" "$2" '^[a-zA-Z0-9._/-]*$' '^--'
> + ds=$2
> + shift
> + ;;
> + *)
> + echo Unknown argument $1
> + usage
> + ;;
> + esac
> + shift
> +done
> +
> +err=
> +nerrs=0
> +for d in 0 1
> +do
> + for t in 0 1 2
> + do
> + for c in 1 2 3
> + do
> + err=
> + val=$((d*1000+t*10+c))
> + tools/testing/selftests/rcutorture/bin/kvm.sh --allcpus --duration 5s --configs "SRCU-P" --bootargs "rcutorture.test_srcu_lockdep=$val" --trust-make --datestamp "$ds/$val" > "$T/kvm.sh.out" 2>&1
> + ret=$?
> + mv "$T/kvm.sh.out" "$RCUTORTURE/res/$ds/$val"
> + if test "$d" -ne 0 && test "$ret" -eq 0
> + then
> + err=1
> + echo -n Unexpected success for > "$RCUTORTURE/res/$ds/$val/kvm.sh.err"
> + fi
> + if test "$d" -eq 0 && test "$ret" -ne 0
> + then
> + err=1
> + echo -n Unexpected failure for > "$RCUTORTURE/res/$ds/$val/kvm.sh.err"
> + fi
> + if test -n "$err"
> + then
> + grep "rcu_torture_init_srcu_lockdep: test_srcu_lockdep = " "$RCUTORTURE/res/$ds/$val/SRCU-P/console.log" | sed -e 's/^.*rcu_torture_init_srcu_lockdep://' >> "$RCUTORTURE/res/$ds/$val/kvm.sh.err"
> + cat "$RCUTORTURE/res/$ds/$val/kvm.sh.err"
> + nerrs=$((nerrs+1))
> + fi
> + done
> + done
> +done
> +if test "$nerrs" -ne 0
> +then
> + exit 1
> +fi
> +exit 0
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-03-20 18:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 3:13 [PATCH rcu 0/7] RCU-related lockdep changes for v6.4 Boqun Feng
2023-03-17 3:13 ` [PATCH rcu 1/7] locking/lockdep: Introduce lock_sync() Boqun Feng
2023-03-20 17:06 ` Davidlohr Bueso
2023-03-20 17:50 ` Boqun Feng
2023-03-17 3:13 ` [PATCH rcu 2/7] rcu: Annotate SRCU's update-side lockdep dependencies Boqun Feng
2023-03-17 3:13 ` [PATCH rcu 3/7] locking: Reduce the number of locks in ww_mutex stress tests Boqun Feng
2023-03-17 18:38 ` Paul E. McKenney
2023-03-17 21:26 ` Boqun Feng
2023-03-17 3:13 ` [PATCH rcu 4/7] locking/lockdep: Improve the deadlock scenario print for sync and read lock Boqun Feng
2023-03-20 12:13 ` Peter Zijlstra
2023-03-20 17:50 ` Boqun Feng
2023-03-17 3:13 ` [PATCH rcu 5/7] rcutorture: Add SRCU deadlock scenarios Boqun Feng
2023-03-17 3:13 ` [PATCH rcu 6/7] rcutorture: Add RCU Tasks Trace and " Boqun Feng
2023-03-17 3:13 ` [PATCH rcu 7/7] rcutorture: Add srcu_lockdep.sh Boqun Feng
2023-03-20 18:19 ` Boqun Feng [this message]
2023-03-20 19:09 ` Paul E. McKenney
2023-03-20 19:28 ` Boqun Feng
2023-03-20 20:22 ` Paul E. McKenney
2023-03-20 20:26 ` Boqun Feng
2023-03-20 20:36 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBijmdz2ucql+BSb@boqun-archlinux \
--to=boqun.feng@gmail.com \
--cc=dave@stgolabs.net \
--cc=dwmw2@infradead.org \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).