From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C456CC7619A for ; Mon, 20 Mar 2023 19:18:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230501AbjCTTSL (ORCPT ); Mon, 20 Mar 2023 15:18:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230274AbjCTTR1 (ORCPT ); Mon, 20 Mar 2023 15:17:27 -0400 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FBBD497F2 for ; Mon, 20 Mar 2023 12:09:22 -0700 (PDT) Received: by mail-pf1-x44a.google.com with SMTP id n22-20020a62e516000000b0062262d6ed76so6620736pff.3 for ; Mon, 20 Mar 2023 12:09:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679339360; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=HUPvCK3ymy0+cnyobGRdsYJBcqoJwtjACAhIOqCIVHU=; b=SDv4oGqnSHYEYEtm5hQgLXiorBu/02OCRZuU/AaNAm3ry0Z6K85YGDlNwDyVSgt7V2 kch1+bYJQLOHK7easWhw8xQqaY9jciwLQdU5k1sy0qPfuJS6rn9dWcR6N+C0RynY7gjD WmMJDCj8hXNzkzSYbq9B1sMH92GfoLkwHZVs2qqzcK5mrIr3F0z8g6IgDAWj7TRSnXRb wYEw70Rd5KrlPpnUqn2DeWJ4ycQysKFZmTGKkPuQHEUupC4nrc2mcSuxIljZtFS5F7Ws C48ynkDgi2qfL0U3x2h+k/Z7Zsj8fIu5SkjMS/0qpdJrAvh71fOgStI0YSdqoUuENV0n eJ9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679339360; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HUPvCK3ymy0+cnyobGRdsYJBcqoJwtjACAhIOqCIVHU=; b=PlCsdsq2b2BrgW9ust1FTOJuPtT606RKlocM1lgBM5bdR8Qk4rj6PtXXXGxkWUX6Xd XAlS/IrVg6/YJdJ/paGMbUwhst0V+8oh3VRQzE3Z1RtgLIoERXqSy2CSXOi2559CcLKM Yx9KJtGnkBgupAln57qnmznliTszZ4eF5HiPQVyqKG9+mMq5Kon+XcKEdxhseatIS/jZ U29A0sZ96faRjl6XwA33Qje6eu9Xnu1cx6L+xB+TzXDVvFoJ0D51cegAqh6W2cFY4iLx eW6x2W98jX2R7fnazkBVs6AD26KEiCaD23MGpUxUIYvJtCKH7S9tBXYWLfIM6DjkQ8Eh pQsQ== X-Gm-Message-State: AO0yUKUMppxCoDxvQY4qTBGqbfWPc1lpcW1SCzwxFtvFoy4vnieKgpQ3 atDkFaYeOfMRBfYQigT17cswzch6/to= X-Google-Smtp-Source: AK7set/AxeSv8Y4jLii27wD+Ebg5sYFCgiwV3KArRehi+kLLw6P9E/Gh3Qez3ZQdbqZXFjXvezfamCQSi/k= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:903:41cc:b0:1a0:440e:ecf9 with SMTP id u12-20020a17090341cc00b001a0440eecf9mr7752314ple.5.1679339359650; Mon, 20 Mar 2023 12:09:19 -0700 (PDT) Date: Mon, 20 Mar 2023 12:09:18 -0700 In-Reply-To: <20230202182809.1929122-1-bgardon@google.com> Mime-Version: 1.0 References: <20230202182809.1929122-1-bgardon@google.com> Message-ID: Subject: Re: [PATCH 00/21] KVM: x86/MMU: Formalize the Shadow MMU From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Xu , David Matlack , Vipin Sharma , Ricardo Koller Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Feb 02, 2023, Ben Gardon wrote: > Patches 4-6 prepare for the refactor by adding files and exporting > functions. For future reference, please do not conflate "export" with "make globally visible" (here and in many of the changelogs). The distinction matters, especially for modules, as an exported symbol is quite different than a globally visible symbol. We (sadly) lose sight of this in KVM far too often due kvm.ko exporting an asburd number of symbols for kvm-{amd,intel}.ko, and as a result we've ended up with non-KVM code using helpers that realy should be KVM-only. This is something I hope to remedy in the near-ish future, and so I want us to start getting the terminology right.