From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218EEC6FD1D for ; Tue, 21 Mar 2023 21:38:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbjCUVi0 (ORCPT ); Tue, 21 Mar 2023 17:38:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229670AbjCUViZ (ORCPT ); Tue, 21 Mar 2023 17:38:25 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9602CDBD3 for ; Tue, 21 Mar 2023 14:38:24 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id k6-20020a170902c40600b001a1d7b0f463so3229372plk.22 for ; Tue, 21 Mar 2023 14:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679434704; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=G0Rv+FDCbn7GlG8ZYRl57/7tDeYBLpzwRQIrpn91yhA=; b=SGuneyhBonT7AIGMuI+e9aO8lp958VZS9TQHcNvOO0mQKDB1I84+TJ/UvPepRDNdct qTNizvZq81n0b69qICnOZDdkyeJJ2PCjsA8F3LLNq0+LD8uRNa6dCMqKgWFPCOJBbsIQ 4p8jiQK41FKlcp4Du10z5+SR3bMwr5f+nQOwG3hI04LdMqsEsqhjFI8WfQp8gRPPXY1i E1GS2+YzVHH13nE8sTqiCX/P5AsBv5rfAjQO8tK28oWc6SfV+UhYPhtvjhZy4ZqW0L28 cZHcxxtdMfefkvJwYK4LSzDt1JVXaYlLqHtgawwPkwHboNIluET7UoAwH1+92SNQ4/1E 95ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679434704; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=G0Rv+FDCbn7GlG8ZYRl57/7tDeYBLpzwRQIrpn91yhA=; b=Vm/+noUW4h050Ue7Lt90HMopJj+AdyPLfgK/jijuZDcF6dYdvMU+YwyqWRkM5lv8oB NQhl52u6GdfdfK053V9KAH7hBh49H7pGE7gJx5kFv/x8dW5JnQIJNxq/6fcXf8vyBJPY KqdxjyryFM0Ye9ife8xYIDQv41TOLE4bU4XsLK17mzhogwHLdm2EMuJaBFD+d8bxsy+f Ff4pENrSVTqFT0kg8SoMGCgYilshE2PA2JqqSrYHz/G3QEIQp+pk1sErgmm4GS3ES8Qq mU0N1dPB2Y6M9ZbAO3h+dxj858Uw/eQiDi6yYTU14fYAggL1QUZogDx2LuZSGp4AioG/ wc9g== X-Gm-Message-State: AO0yUKU1+z3dLCLk8EGRopXXJ6TE5yxZ0cF7t8ToFhua0P9hjG6d+nrh +k311/l4/11y/P6uBmavaeu3qIsptXs= X-Google-Smtp-Source: AK7set9Ad2gBkvSRJpVrwWh1laoJXrL8OL7BCZkq1AP5GX4jqPjlsahoWbJH6kgiGOfeo3/4qdRwOX0/yFI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a65:66d4:0:b0:507:68f8:4369 with SMTP id c20-20020a6566d4000000b0050768f84369mr121854pgw.12.1679434704147; Tue, 21 Mar 2023 14:38:24 -0700 (PDT) Date: Tue, 21 Mar 2023 14:38:22 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230211014626.3659152-1-vipinsh@google.com> Message-ID: Subject: Re: [Patch v3 0/7] Optimize clear dirty log From: Sean Christopherson To: Vipin Sharma Cc: pbonzini@redhat.com, bgardon@google.com, dmatlack@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Mar 21, 2023, Sean Christopherson wrote: > It won't. MMU_WARN_ON() is dead code without manual modification to defi= ne MMU_DEBUG. > Part of the reason I used MMU_WARN_ON() was to remind myself to send a pa= tch/series > to overhaul MMU_WARN_ON[*]. My thought/hope is that a Kconfig will allow= developers > and testers to run with a pile of assertions and sanity checks without im= pacting > the runtime overhead for production builds. >=20 > [*] https://lore.kernel.org/all/Yz4Qi7cn7TWTWQjj@google.com/ Ugh, I'm definitely sending that patch, MMU_DEBUG has bitrotted and broken = the build yet again. arch/x86/kvm/mmu/mmu.c: In function =E2=80=98kvm_mmu_free_shadow_page=E2=80= =99: arch/x86/kvm/mmu/mmu.c:1738:15: error: implicit declaration of function =E2= =80=98is_empty_shadow_page=E2=80=99; did you mean =E2=80=98to_shadow_page= =E2=80=99? [-Werror=3Dimplicit-function-declaration] 1738 | MMU_WARN_ON(!is_empty_shadow_page(sp->spt)); | ^~~~~~~~~~~~~~~~~~~~ include/asm-generic/bug.h:110:25: note: in definition of macro =E2=80=98WAR= N_ON_ONCE=E2=80=99 110 | int __ret_warn_on =3D !!(condition); \ | ^~~~~~~~~ arch/x86/kvm/mmu/mmu.c:1738:2: note: in expansion of macro =E2=80=98MMU_WAR= N_ON=E2=80=99 1738 | MMU_WARN_ON(!is_empty_shadow_page(sp->spt)); | ^~~~~~~~~~~