From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B82C7EE32 for ; Wed, 24 May 2023 21:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235917AbjEXVj4 (ORCPT ); Wed, 24 May 2023 17:39:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233142AbjEXVjy (ORCPT ); Wed, 24 May 2023 17:39:54 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87FE6132 for ; Wed, 24 May 2023 14:39:53 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-561eb6c66f6so16825297b3.0 for ; Wed, 24 May 2023 14:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684964392; x=1687556392; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=u+lTI9LGfJCIeH9eUZOS37jnh9XivOrfiNHxwExkkPU=; b=1OM2n6A6XJR4jj8vE2JD/qVka6KhOa37sATKkJGdtzfw5ejGSX46cgRyM3KxfTglOD 0RNiltYW0aqpSJK1ylM7pyVuNywmw3i8GLhqy6D8KbpUnlsiq///5XlVQOyARTMakL95 sruDKzgA0kJWIRgwdNf60tHMZ2lnfSldT/PHutYtTTub50wqJp62S52UJsWvKQ7jpGPj JBND0HA8P6pXYHkEPXwT4zPgdYSplBBE7ttHpAHPL1RPyn6nSmxfEos2auwOVntQ9sEN x6n9gU3Z0Y/wI8zE55ONSW8DBiSo/6ReRvhBCmqYQEuA2BiS/6yDjqxNIpbAGpQ1wAiT KtGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684964392; x=1687556392; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u+lTI9LGfJCIeH9eUZOS37jnh9XivOrfiNHxwExkkPU=; b=Xr729gmRCR19z8IEMMFAKI0ViFo2tnk5E3zHlIUC/RUEqVRp0wfA8do0L6KaxSKcv4 DPi5HKHJa8UbfQP73zGYTdb8TZOy3yQBNZEmB2eJr3LgoSQwgBX3+eZpI3wg9ZYjs1Vz chYg3pfVVJtfqIMbA5ywhD5LOmAZk1bCsvkgIeq5iLLoKCphmIrGzCahT4z5WknYhB+B DzHCQ0ztoZBnuyRH9gmpoyitreYg6zlhGoM/xt0K2LTanXEkD6jQdg2XZAsv0QjuecrU lEfjN8eD1zONAkJg/XS106Bb8UEDyJ6h0FcbBcMf1jv35SxiKKC24wCiSF79jbqTUb4m ezTg== X-Gm-Message-State: AC+VfDyUvOE7hP/I5fglcaSxvTEKNsw3ziEgE/I5DtDak0rFgSlP75Qh gvl30/nVuNtStDQq4A0jg0AM2uoRBo4= X-Google-Smtp-Source: ACHHUZ4gGkG32f/WDPDY+8DnC86QiU6Z2uyq9N2VVLscH3WfhLiakxSPFeyk8pWCaiTnq1AgYyU2vpbztC4= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:ae14:0:b0:561:8bfb:feb1 with SMTP id m20-20020a81ae14000000b005618bfbfeb1mr12005442ywh.10.1684964392193; Wed, 24 May 2023 14:39:52 -0700 (PDT) Date: Wed, 24 May 2023 14:39:50 -0700 In-Reply-To: <20230524203336.GC3447678@hirez.programming.kicks-ass.net> Mime-Version: 1.0 References: <20220706082016.2603916-1-chao.p.peng@linux.intel.com> <20220706082016.2603916-9-chao.p.peng@linux.intel.com> <20230524203336.GC3447678@hirez.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH v7 08/14] KVM: Rename mmu_notifier_* From: Sean Christopherson To: Peter Zijlstra Cc: Kautuk Consul , Chao Peng , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, May 24, 2023, Peter Zijlstra wrote: > On Wed, May 24, 2023 at 01:16:03PM -0700, Sean Christopherson wrote: > > Of course, the only accesses outside of mmu_lock are reads, so on x86 that > > "atomic" access is just a READ_ONCE() load, but that's not the case for all > > architectures. > > This is true on *all* archs. atomic_set() and atomic_read() are no more > and no less than WRITE_ONCE() / READ_ONCE(). Ah, I take it s390's handcoded assembly routines are just a paranoid equivalents and not truly special? "l" and "st" do sound quite generic... commit 7657e41a0bd16c9d8b3cefe8fd5d6ac3c25ae4bf Author: Heiko Carstens Date: Thu Feb 17 13:13:58 2011 +0100 [S390] atomic: use inline asm Use inline assemblies for atomic_read/set(). This way there shouldn't be any questions or subtle volatile semantics left. static inline int __atomic_read(const atomic_t *v) { int c; asm volatile( " l %0,%1\n" : "=d" (c) : "R" (v->counter)); return c; } static inline void __atomic_set(atomic_t *v, int i) { asm volatile( " st %1,%0\n" : "=R" (v->counter) : "d" (i)); }