From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Janis Schoetterl-Glausch <scgl@linux.vnet.ibm.com>,
Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
"open list:KERNEL VIRTUAL MACHINE for s390 (KVM/s390)"
<kvm@vger.kernel.org>,
"open list:S390" <linux-s390@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: s390: Enable specification exception interpretation
Date: Wed, 7 Jul 2021 10:59:29 +0200 [thread overview]
Message-ID: <a2e3484a-34af-0bab-2fb3-b22a69361807@de.ibm.com> (raw)
In-Reply-To: <c61223e4-0076-18c1-64bd-8ba899e91eb4@linux.vnet.ibm.com>
On 07.07.21 10:56, Janis Schoetterl-Glausch wrote:
> On 7/7/21 10:30 AM, Christian Borntraeger wrote:
>>
>>
>> On 06.07.21 13:47, Janis Schoetterl-Glausch wrote:
>>> When this feature is enabled the hardware is free to interpret
>>> specification exceptions generated by the guest, instead of causing
>>> program interruption interceptions.
>>>
>>> This benefits (test) programs that generate a lot of specification
>>> exceptions (roughly 4x increase in exceptions/sec).
>>>
>>> Interceptions will occur as before if ICTL_PINT is set,
>>> i.e. if guest debug is enabled.
>>
>> I think I will add
>>
>> There is no indication if this feature is available or not and the hardware
>> is free to interpret or not. So we can simply set this bit and if the
>> hardware ignores it we fall back to intercept 8 handling.
>
> Might also mention vSIE and/or incorporate into first paragraph:
>
> When this feature is enabled the hardware is free to interpret
> specification exceptions generated by the guest, instead of causing
> program interruption interceptions, but it is not required to.
> There is no indication if this feature is available or not,
> so we can simply set this bit and if the hardware ignores it
> we fall back to intercept 8 handling.
> The same applies to vSIE, we forward the guest hypervisor's bit
> and fall back to injection if interpretation does not occur.
Can you maybe resend a v2 with all comments (and RBs) added?
prev parent reply other threads:[~2021-07-07 8:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 11:47 [PATCH] KVM: s390: Enable specification exception interpretation Janis Schoetterl-Glausch
2021-07-06 11:52 ` Cornelia Huck
2021-07-06 11:56 ` Christian Borntraeger
2021-07-06 11:59 ` David Hildenbrand
2021-07-06 12:02 ` Christian Borntraeger
2021-07-06 15:16 ` David Hildenbrand
2021-07-06 15:27 ` Janis Schoetterl-Glausch
2021-07-07 7:26 ` David Hildenbrand
2021-07-06 11:55 ` David Hildenbrand
2021-07-07 8:30 ` Christian Borntraeger
2021-07-07 8:54 ` Cornelia Huck
2021-07-07 9:55 ` Janis Schoetterl-Glausch
2021-07-07 11:42 ` Cornelia Huck
2021-07-07 8:56 ` Janis Schoetterl-Glausch
2021-07-07 8:59 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2e3484a-34af-0bab-2fb3-b22a69361807@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=scgl@linux.ibm.com \
--cc=scgl@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).