kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexandru Elisei <alexandru.elisei@arm.com>, kvm@vger.kernel.org
Subject: Re: [PATCH kvm-unit-tests 1/2] libcflat: clean up and complete long division routines
Date: Wed, 12 May 2021 12:47:59 +0200	[thread overview]
Message-ID: <a3216c48-3e96-8d8d-290e-25d7754874be@redhat.com> (raw)
In-Reply-To: <3255ae16-ee2d-861d-d7e8-9360e7eaa09c@arm.com>

On 12/05/21 12:39, Alexandru Elisei wrote:
>> +
>> +	/* Copy sign of num^den into quotient, sign of num into remainder.  */
>> +	quot = (__divmoddi4(num, den, p_rem) + qmask) ^ qmask;
> I see no early return statement in the function, it looks to me like the function
> will recurse forever. Maybe you wanted to call here __*u*divmoddi4() (emphasis
> added) instead?

Of course...

Paolo


  reply	other threads:[~2021-05-12 10:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 17:41 [PATCH kvm-unit-tests 0/2] fix long division routines for ARM eabi Paolo Bonzini
2021-05-11 17:41 ` [PATCH kvm-unit-tests 1/2] libcflat: clean up and complete long division routines Paolo Bonzini
2021-05-12 10:39   ` Alexandru Elisei
2021-05-12 10:47     ` Paolo Bonzini [this message]
2021-05-11 17:41 ` [PATCH kvm-unit-tests 2/2] arm: add eabi version of 64-bit division functions Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3216c48-3e96-8d8d-290e-25d7754874be@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alexandru.elisei@arm.com \
    --cc=kvm@vger.kernel.org \
    --subject='Re: [PATCH kvm-unit-tests 1/2] libcflat: clean up and complete long division routines' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).