From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035EAC43460 for ; Wed, 12 May 2021 10:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C26FD61370 for ; Wed, 12 May 2021 10:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230301AbhELKtM (ORCPT ); Wed, 12 May 2021 06:49:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57248 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbhELKtM (ORCPT ); Wed, 12 May 2021 06:49:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620816484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/HawenKJcX93/Kf64cToc0lOfSdPyP11wwRNo7KhYrQ=; b=aOpWHZwqcw7JaF+/VYUg+sOesV4pvLrScKzjvcjnQyTYEHOxsxmrorbaVKKkJ+FULHBAAS qFlLvijELhNVfqdJ4VAjWtamwO8fcuifskxKhsRbUc26u3wlNC/zQazvmFh1nfg+S5Y7DO Aax1hnWSB8a+lLMemlDQbxHiMrrnZN8= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-DqgmDU3UNEWBC_N6yHHrGA-1; Wed, 12 May 2021 06:48:02 -0400 X-MC-Unique: DqgmDU3UNEWBC_N6yHHrGA-1 Received: by mail-ed1-f69.google.com with SMTP id h18-20020a05640250d2b029038cc3938914so917703edb.17 for ; Wed, 12 May 2021 03:48:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/HawenKJcX93/Kf64cToc0lOfSdPyP11wwRNo7KhYrQ=; b=Lm9AeqGbdup7dnERoEwZ2TxGxQlY6sM6+dzQR1gkaj0dnQBPd9c2X2s6tmk6F6iW8p cF6TfOz1Ok14XouyXfExYLd0jgQaM2dgLF6QdwOIxgu4CcFwgObqvRlRU44XOlsfKNfx jbOF9m8zIlpJ/+1iI3o8U4yCz4JpGdEyi5FFSuR3YEPNmDThkBiIBQMwjQsNqWYaHC5O s+2L/K6G9nbmFY2hymkoVKpipDWMIaUsVLef9tBQxcAK1pBtKyb9/v9Qn8bpTGDojl9v HR28Ip43D1GbL0PIJP1fx+SAL4oqvdZon0f/c1OfePfimxBa+9u5weGP6HjJOdgtWDUC CK1w== X-Gm-Message-State: AOAM532VWNc2+rUX8RacPWraskFK+gElrzuaJN7Jnq0mf93YQoifWCHA ObDvRSAnjlc1uoLAStlynu3KNpUL+wEmSeVZhBLc1W1RZcv810YxdQgtNyiIkk5C+p3SwfVOWW4 kc0GDJv08/Z3XTNe3tPzwAJKXJhNKi2U5NeMkBHCJnaA45EbyT94WHouM0YPOcAEM X-Received: by 2002:a17:906:3bc6:: with SMTP id v6mr37588365ejf.165.1620816481148; Wed, 12 May 2021 03:48:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2zBNiswoVfm3HtObttQYz8ODuLWKT2lh+0kVm2RbahjhxjB8/sCVU71ON375Nj2dBcjYQ1A== X-Received: by 2002:a17:906:3bc6:: with SMTP id v6mr37588352ejf.165.1620816480861; Wed, 12 May 2021 03:48:00 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id o13sm14091324ejx.86.2021.05.12.03.47.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 May 2021 03:48:00 -0700 (PDT) Subject: Re: [PATCH kvm-unit-tests 1/2] libcflat: clean up and complete long division routines To: Alexandru Elisei , kvm@vger.kernel.org References: <20210511174106.703235-1-pbonzini@redhat.com> <20210511174106.703235-2-pbonzini@redhat.com> <3255ae16-ee2d-861d-d7e8-9360e7eaa09c@arm.com> From: Paolo Bonzini Message-ID: Date: Wed, 12 May 2021 12:47:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <3255ae16-ee2d-861d-d7e8-9360e7eaa09c@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 12/05/21 12:39, Alexandru Elisei wrote: >> + >> + /* Copy sign of num^den into quotient, sign of num into remainder. */ >> + quot = (__divmoddi4(num, den, p_rem) + qmask) ^ qmask; > I see no early return statement in the function, it looks to me like the function > will recurse forever. Maybe you wanted to call here __*u*divmoddi4() (emphasis > added) instead? Of course... Paolo