From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Brijesh Singh <brijesh.singh@amd.com>,
kvm@vger.kernel.org, Sergio Lopez <slp@redhat.com>,
Connor Kuehl <ckuehl@redhat.com>,
James Bottomley <jejb@linux.ibm.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Dov Murik <dovmurik@linux.ibm.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH v3 08/22] target/i386/sev: Remove sev_get_me_mask()
Date: Mon, 4 Oct 2021 10:11:42 +0200 [thread overview]
Message-ID: <a44a2967-a8d5-8fc1-d755-3fe1456370a6@redhat.com> (raw)
In-Reply-To: <20211002125317.3418648-9-philmd@redhat.com>
On 02/10/21 14:53, Philippe Mathieu-Daudé wrote:
> Unused dead code makes review harder, so remove it.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> target/i386/sev_i386.h | 1 -
> target/i386/sev-stub.c | 5 -----
> target/i386/sev.c | 9 ---------
> 3 files changed, 15 deletions(-)
>
> diff --git a/target/i386/sev_i386.h b/target/i386/sev_i386.h
> index f4223f1febf..afa19a0a161 100644
> --- a/target/i386/sev_i386.h
> +++ b/target/i386/sev_i386.h
> @@ -25,7 +25,6 @@
> #define SEV_POLICY_SEV 0x20
>
> extern bool sev_es_enabled(void);
> -extern uint64_t sev_get_me_mask(void);
> extern SevInfo *sev_get_info(void);
> extern uint32_t sev_get_cbit_position(void);
> extern uint32_t sev_get_reduced_phys_bits(void);
> diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c
> index d91c2ece784..eb0c89bf2be 100644
> --- a/target/i386/sev-stub.c
> +++ b/target/i386/sev-stub.c
> @@ -25,11 +25,6 @@ bool sev_enabled(void)
> return false;
> }
>
> -uint64_t sev_get_me_mask(void)
> -{
> - return ~0;
> -}
> -
> uint32_t sev_get_cbit_position(void)
> {
> return 0;
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index fa7210473a6..c88cd808410 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -64,7 +64,6 @@ struct SevGuestState {
> uint8_t api_major;
> uint8_t api_minor;
> uint8_t build_id;
> - uint64_t me_mask;
> int sev_fd;
> SevState state;
> gchar *measurement;
> @@ -362,12 +361,6 @@ sev_es_enabled(void)
> return sev_enabled() && (sev_guest->policy & SEV_POLICY_ES);
> }
>
> -uint64_t
> -sev_get_me_mask(void)
> -{
> - return sev_guest ? sev_guest->me_mask : ~0;
> -}
> -
> uint32_t
> sev_get_cbit_position(void)
> {
> @@ -804,8 +797,6 @@ int sev_kvm_init(ConfidentialGuestSupport *cgs, Error **errp)
> goto err;
> }
>
> - sev->me_mask = ~(1UL << sev->cbitpos);
> -
> devname = object_property_get_str(OBJECT(sev), "sev-device", NULL);
> sev->sev_fd = open(devname, O_RDWR);
> if (sev->sev_fd < 0) {
>
RB
next prev parent reply other threads:[~2021-10-04 8:11 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 12:52 [PATCH v3 00/22] target/i386/sev: Housekeeping SEV + measured Linux SEV guest Philippe Mathieu-Daudé
2021-10-02 12:52 ` [PATCH v3 01/22] qapi/misc-target: Wrap long 'SEV Attestation Report' long lines Philippe Mathieu-Daudé
2021-10-04 8:05 ` Paolo Bonzini
2021-10-02 12:52 ` [PATCH v3 02/22] qapi/misc-target: Group SEV QAPI definitions Philippe Mathieu-Daudé
2021-10-04 8:05 ` Paolo Bonzini
2021-10-02 12:52 ` [PATCH v3 03/22] target/i386/kvm: Introduce i386_softmmu_kvm Meson source set Philippe Mathieu-Daudé
2021-10-04 8:06 ` Paolo Bonzini
2021-10-02 12:52 ` [PATCH v3 04/22] target/i386/kvm: Restrict SEV stubs to x86 architecture Philippe Mathieu-Daudé
2021-10-04 8:06 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 05/22] target/i386/monitor: Return QMP error when SEV is disabled in build Philippe Mathieu-Daudé
2021-10-04 8:11 ` Paolo Bonzini
2021-10-07 11:29 ` Philippe Mathieu-Daudé
2021-10-07 12:25 ` Dr. David Alan Gilbert
2021-10-02 12:53 ` [PATCH v3 06/22] target/i386/cpu: Add missing 'qapi/error.h' header Philippe Mathieu-Daudé
2021-10-04 8:11 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 07/22] target/i386/sev_i386.h: Remove unused headers Philippe Mathieu-Daudé
2021-10-04 8:11 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 08/22] target/i386/sev: Remove sev_get_me_mask() Philippe Mathieu-Daudé
2021-10-04 8:11 ` Paolo Bonzini [this message]
2021-10-04 8:11 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 09/22] target/i386/sev: Mark unreachable code with g_assert_not_reached() Philippe Mathieu-Daudé
2021-10-04 8:12 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 10/22] target/i386/sev: sev_get_attestation_report use g_autofree Philippe Mathieu-Daudé
2021-10-04 8:13 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 11/22] target/i386/sev: Restrict SEV to system emulation Philippe Mathieu-Daudé
2021-10-04 8:14 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 12/22] target/i386/sev: Declare system-specific functions in 'sev_i386.h' Philippe Mathieu-Daudé
2021-10-04 8:15 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 13/22] target/i386/sev: Remove stubs by using code elision Philippe Mathieu-Daudé
2021-10-04 8:19 ` Paolo Bonzini
2021-10-06 18:55 ` Philippe Mathieu-Daudé
2021-10-08 15:46 ` Brijesh Singh
2021-10-02 12:53 ` [PATCH v3 14/22] target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c Philippe Mathieu-Daudé
2021-10-04 8:23 ` Paolo Bonzini
2021-10-06 20:45 ` Philippe Mathieu-Daudé
2021-10-04 9:57 ` Dr. David Alan Gilbert
2021-10-07 9:48 ` Philippe Mathieu-Daudé
2021-10-02 12:53 ` [PATCH v3 15/22] target/i386/sev: Move qmp_sev_inject_launch_secret() " Philippe Mathieu-Daudé
2021-10-04 8:24 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 16/22] target/i386/sev: Move qmp_query_sev_capabilities() " Philippe Mathieu-Daudé
2021-10-04 8:24 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 17/22] target/i386/sev: Move qmp_query_sev_launch_measure() " Philippe Mathieu-Daudé
2021-10-04 8:24 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 18/22] target/i386/sev: Move qmp_query_sev() & hmp_info_sev() " Philippe Mathieu-Daudé
2021-10-04 8:24 ` Paolo Bonzini
2021-10-02 12:53 ` [PATCH v3 19/22] monitor: Restrict 'info sev' to x86 targets Philippe Mathieu-Daudé
2021-10-04 8:26 ` Paolo Bonzini
2021-10-07 15:18 ` Philippe Mathieu-Daudé
2021-10-02 12:53 ` [PATCH v3 20/22] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot Philippe Mathieu-Daudé
2021-10-02 12:53 ` [PATCH v3 21/22] x86/sev: generate SEV kernel loader hashes in x86_load_linux Philippe Mathieu-Daudé
2021-10-02 12:53 ` [PATCH v3 22/22] MAINTAINERS: Cover AMD SEV files Philippe Mathieu-Daudé
2021-10-04 8:27 ` Paolo Bonzini
2021-10-06 20:35 ` Philippe Mathieu-Daudé
2021-10-04 8:27 ` [PATCH v3 00/22] target/i386/sev: Housekeeping SEV + measured Linux SEV guest Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a44a2967-a8d5-8fc1-d755-3fe1456370a6@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=brijesh.singh@amd.com \
--cc=ckuehl@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dovmurik@linux.ibm.com \
--cc=ehabkost@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).