From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC459C433DB for ; Wed, 10 Mar 2021 16:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB7BE64F9B for ; Wed, 10 Mar 2021 16:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231366AbhCJQD6 (ORCPT ); Wed, 10 Mar 2021 11:03:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41922 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232574AbhCJQDt (ORCPT ); Wed, 10 Mar 2021 11:03:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615392228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T6LZWP2vn4gZYNN60dpd9pTIeb1KCd0er7xtszZkk6U=; b=bhKXKhxw+ZSn/71Tksjz1NmcU1+mwOomex78JYC/oYUjKLGc3teEQ8M2d+jR61pb6M2IGb OoWJjeBzLF/a5NOAqjYcvbSH26haJKbdVJR9rJVHIUIB+LHW09EOoahiJZU6YRlQFmhM5C VVnJ/7symILjjKRlE4F0qBcEISc1YSQ= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-575-AS4NCR6dMUSV4pEI7SY2hg-1; Wed, 10 Mar 2021 11:03:46 -0500 X-MC-Unique: AS4NCR6dMUSV4pEI7SY2hg-1 Received: by mail-ed1-f70.google.com with SMTP id p12so8586949edw.9 for ; Wed, 10 Mar 2021 08:03:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T6LZWP2vn4gZYNN60dpd9pTIeb1KCd0er7xtszZkk6U=; b=P8Yqmqoauw9yt7N5qJgwIrOd4YOAAybwk/T5MS++eDjvFJmXCxJhhuyZ/Z1qu+lhYf ml4gBrDnZOz0dnRr2hKkX4v5mmYgwl6ABFK+YBhQoqQ6agOcSV+RLmELbOanUzm0jg7Z 0P/n+ihy33seaXp4WqS/ZqKIC+bmJJdePDPMude6e9N1ViESHUNwEP58Lqh9KvvtdLPL 8MaTN633RgnlpO9363a7u+tRhwM97m1lYLgHMTCsvo9+I97+zgniYQIarATRpeNvJ48r /jWf5lzslRXjbaKoYyhbyofUtRbbsKeJW7B0jxvaxXdGUWVSjvIDmdFDdzXPDw9BxVKy qldQ== X-Gm-Message-State: AOAM533G0BtI1fevlFhftWfjF7AxDj/RrqCvHCXdR2G6UrOTLPwLXUX7 dGL8tIq30/DMYA4K7AldCJPXuwIluWzAvxbZ5tceOgUqOJq80fIAjiHWV0JKryA/bQNgW3gfymU zZkWozu1SIPO7 X-Received: by 2002:a17:906:c0c8:: with SMTP id bn8mr4365532ejb.445.1615392225074; Wed, 10 Mar 2021 08:03:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1V5iKaTO/Dprgp6gE22d8iEwpMy8ZGDfQA++8bp2mD+TtXAT0OFzpxwvgV6mj5ydH3tp6rw== X-Received: by 2002:a17:906:c0c8:: with SMTP id bn8mr4365501ejb.445.1615392224882; Wed, 10 Mar 2021 08:03:44 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id k9sm8884545edn.68.2021.03.10.08.03.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Mar 2021 08:03:44 -0800 (PST) Subject: Re: [RFC PATCH 3/4] KVM: stats: Add ioctl commands to pull statistics in binary format To: Marc Zyngier , Jing Zhang Cc: KVM , KVM ARM , Linux MIPS , KVM PPC , Linux S390 , Linux kselftest , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito References: <20210310003024.2026253-1-jingzhangos@google.com> <20210310003024.2026253-4-jingzhangos@google.com> <875z1zxb11.wl-maz@kernel.org> From: Paolo Bonzini Message-ID: Date: Wed, 10 Mar 2021 17:03:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <875z1zxb11.wl-maz@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 10/03/21 16:51, Marc Zyngier wrote: >> + kvm_for_each_vcpu(j, vcpu, kvm) { >> + pdata = data + VM_STAT_COUNT; >> + for (i = 0; i < VCPU_STAT_COUNT; i++, pdata++) >> + *pdata += *((u64 *)&vcpu->stat + i); > Do you really need the in-kernel copy? Why not directly organise the > data structures in a way that would allow a bulk copy using > copy_to_user()? The result is built by summing per-vCPU counters, so that the counter updates are fast and do not require a lock. So consistency basically cannot be guaranteed. Paolo