From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819C0C433E0 for ; Thu, 21 Jan 2021 09:27:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B05F2399A for ; Thu, 21 Jan 2021 09:27:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728677AbhAUJ0u (ORCPT ); Thu, 21 Jan 2021 04:26:50 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50678 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728320AbhAUJU4 (ORCPT ); Thu, 21 Jan 2021 04:20:56 -0500 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 10L92Tri140419; Thu, 21 Jan 2021 04:20:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=zmiHxZF+KdKsdkIAlIVz+JM5U9W387S6gaHJi1yZNxI=; b=GRQLxEHqCocr6KT8+bg9VTuD8xzXsSLvja6saG9OQSOyG1leAxE1Z7FUkPXZn7NqAXMn pqitkM3peBiw4loum6n6Ps8oeynK5SrhI0NFDpQBJWfD11GRODuRnmS339I80OnRejgR 0gw3DJneIXPA+snWV5WsfmT7uLBqNEnhl2DI4US9CVZN7Gk85VNrKWu2asjJbQZLV1hd +FHK1uLP90/2t98jflbqOdeUL6R13MDY2vW2xz5wxNnPz+WdsvHqkvf5tEuTmfyUlm6x h7FP+Pqt/Hv1ZdeXvxJCoPWgneOWIKIlgxwjsWbhpNixm7uyznQeBUOHX/OblYyl2koo bA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3675ra2ar3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jan 2021 04:20:10 -0500 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 10L93DkG143376; Thu, 21 Jan 2021 04:20:10 -0500 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 3675ra2apy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jan 2021 04:20:10 -0500 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 10L9Gcc6022465; Thu, 21 Jan 2021 09:20:08 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma06ams.nl.ibm.com with ESMTP id 3668nwsg7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jan 2021 09:20:07 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 10L9K58w46006696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Jan 2021 09:20:05 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 25B9211C04C; Thu, 21 Jan 2021 09:20:05 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9983211C04A; Thu, 21 Jan 2021 09:20:04 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.165.35]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 21 Jan 2021 09:20:04 +0000 (GMT) Subject: Re: [kvm-unit-tests PATCH v4 1/3] s390x: pv: implement routine to share/unshare memory To: Pierre Morel , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, david@redhat.com, thuth@redhat.com, cohuck@redhat.com, imbrenda@linux.ibm.com, drjones@redhat.com, pbonzini@redhat.com References: <1611220392-22628-1-git-send-email-pmorel@linux.ibm.com> <1611220392-22628-2-git-send-email-pmorel@linux.ibm.com> From: Janosch Frank Message-ID: Date: Thu, 21 Jan 2021 10:20:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <1611220392-22628-2-git-send-email-pmorel@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2021-01-21_03:2021-01-20,2021-01-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 spamscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101210045 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 1/21/21 10:13 AM, Pierre Morel wrote: > When communicating with the host we need to share part of > the memory. > > Let's implement the ultravisor calls for this. > > Signed-off-by: Pierre Morel > Suggested-by: Janosch Frank > Acked-by: Cornelia Huck > Acked-by: Thomas Huth > --- > lib/s390x/asm/uv.h | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/lib/s390x/asm/uv.h b/lib/s390x/asm/uv.h > index 4c2fc48..8400026 100644 > --- a/lib/s390x/asm/uv.h > +++ b/lib/s390x/asm/uv.h > @@ -71,4 +71,42 @@ static inline int uv_call(unsigned long r1, unsigned long r2) > return cc; > } > > +static inline int share(unsigned long addr, u16 cmd) > +{ > + struct uv_cb_share uvcb = { > + .header.cmd = cmd, > + .header.len = sizeof(uvcb), > + .paddr = addr > + }; > + int cc; > + > + cc = uv_call(0, (u64)&uvcb); > + if (!cc && uvcb.header.rc == 0x0001) s/0x0001/UVC_RC_EXECUTED/ > + return 0; > + > + report_info("cc %d response code: %04x", cc, uvcb.header.rc); Will the print have the string UV in it or will I need to guess that a UV call failed? I'm wondering if an assert would make more sense, if callers are interested in the uv rc they will need to write an own share function anyway. > + return -1; > +} > + > +/* > + * Guest 2 request to the Ultravisor to make a page shared with the > + * hypervisor for IO. > + * > + * @addr: Real or absolute address of the page to be shared > + */ > +static inline int uv_set_shared(unsigned long addr) > +{ > + return share(addr, UVC_CMD_SET_SHARED_ACCESS); > +} > + > +/* > + * Guest 2 request to the Ultravisor to make a page unshared. > + * > + * @addr: Real or absolute address of the page to be unshared > + */ > +static inline int uv_remove_shared(unsigned long addr) > +{ > + return share(addr, UVC_CMD_REMOVE_SHARED_ACCESS); > +} > + > #endif >