kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>,
	Stefano De Venuto <stefano.devenuto99@gmail.com>
Cc: linux-kernel@vger.kernel.org, vkuznets@redhat.com,
	wanpengli@tencent.com, jmattson@google.com, x86@kernel.org,
	hpa@zytor.com, kvm@vger.kernel.org, rostedt@goodmis.org,
	y.karadz@gmail.com, Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH] Move VMEnter and VMExit tracepoints closer to the actual event
Date: Thu, 20 May 2021 18:18:38 +0200	[thread overview]
Message-ID: <ab44e5b1-4448-d6c8-6cda-5e41866f69f1@redhat.com> (raw)
In-Reply-To: <YKaBEn6oUXaVAb0K@google.com>

On 20/05/21 17:32, Sean Christopherson wrote:
> On VMX, I think the tracepoint can be moved below the VMWRITEs without much
> contention (though doing so is likely a nop), but moving it below
> kvm_load_guest_xsave_state() requires a bit more discussion.

Indeed; as a rule of thumb, the tracepoint on SVM could match the 
clgi/stgi region, and on VMX it could be placed in a similar location.

Paolo

> I 100% agree that the current behavior can be a bit confusing, but I wonder if
> we'd be better off "solving" that problem through documentation.


  reply	other threads:[~2021-05-20 16:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 18:23 [PATCH] Move VMEnter and VMExit tracepoints closer to the actual event Stefano De Venuto
2021-05-20  6:05 ` Dario Faggioli
2021-05-20  7:21 ` Thomas Gleixner
2021-05-21  7:13   ` Dario Faggioli
2021-05-20 15:32 ` Sean Christopherson
2021-05-20 16:18   ` Paolo Bonzini [this message]
2021-05-21  7:58     ` Dario Faggioli
2021-05-28 16:55     ` Dario Faggioli
2021-05-28 16:57       ` Paolo Bonzini
2021-05-21  7:51   ` Dario Faggioli
2021-05-25 16:20     ` Sean Christopherson
2021-05-28 17:03       ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab44e5b1-4448-d6c8-6cda-5e41866f69f1@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dfaggioli@suse.com \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=seanjc@google.com \
    --cc=stefano.devenuto99@gmail.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).