From: Bart Van Assche <bvanassche@acm.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, stefanha@redhat.com
Subject: Re: [PATCH 1/2] scsi_host: add support for request batching
Date: Thu, 30 May 2019 08:36:30 -0700 [thread overview]
Message-ID: <ad0578b0-ce73-85ed-b67d-70c5d8176a23@acm.org> (raw)
In-Reply-To: <20190530112811.3066-2-pbonzini@redhat.com>
On 5/30/19 4:28 AM, Paolo Bonzini wrote:
> +static const struct blk_mq_ops scsi_mq_ops_no_commit = {
> + .get_budget = scsi_mq_get_budget,
> + .put_budget = scsi_mq_put_budget,
> + .queue_rq = scsi_queue_rq,
> + .complete = scsi_softirq_done,
> + .timeout = scsi_timeout,
> +#ifdef CONFIG_BLK_DEBUG_FS
> + .show_rq = scsi_show_rq,
> +#endif
> + .init_request = scsi_mq_init_request,
> + .exit_request = scsi_mq_exit_request,
> + .initialize_rq_fn = scsi_initialize_rq,
> + .busy = scsi_mq_lld_busy,
> + .map_queues = scsi_map_queues,
> +};
> +
> +static void scsi_commit_rqs(struct blk_mq_hw_ctx *hctx)
> +{
> + struct request_queue *q = hctx->queue;
> + struct scsi_device *sdev = q->queuedata;
> + struct Scsi_Host *shost = sdev->host;
> +
> + shost->hostt->commit_rqs(shost, hctx->queue_num);
> +}
> +
> static const struct blk_mq_ops scsi_mq_ops = {
> .get_budget = scsi_mq_get_budget,
> .put_budget = scsi_mq_put_budget,
> .queue_rq = scsi_queue_rq,
> + .commit_rqs = scsi_commit_rqs,
> .complete = scsi_softirq_done,
> .timeout = scsi_timeout,
> #ifdef CONFIG_BLK_DEBUG_FS
Hi Paolo,
Have you considered to modify the block layer such that a single
scsi_mq_ops structure can be used for all SCSI LLD types?
Thanks,
Bart.
next prev parent reply other threads:[~2019-05-30 15:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 11:28 [PATCH 0/2] scsi: add support for request batching Paolo Bonzini
2019-05-30 11:28 ` [PATCH 1/2] scsi_host: " Paolo Bonzini
2019-05-30 15:36 ` Bart Van Assche [this message]
2019-05-30 15:54 ` Paolo Bonzini
2019-05-30 17:54 ` Bart Van Assche
2019-05-31 9:12 ` Paolo Bonzini
2019-05-31 3:27 ` Ming Lei
2019-06-03 8:16 ` Paolo Bonzini
2019-07-05 1:00 ` Ming Lei
2019-06-04 22:40 ` Bart Van Assche
2019-06-19 8:11 ` Hannes Reinecke
2019-06-19 10:31 ` Paolo Bonzini
2019-07-04 13:19 ` Paolo Bonzini
2019-07-05 7:12 ` Hannes Reinecke
2019-07-05 7:44 ` Stefan Hajnoczi
2019-07-05 7:51 ` Hannes Reinecke
2019-05-30 11:28 ` [PATCH 2/2] virtio_scsi: implement " Paolo Bonzini
2019-05-30 17:28 ` Bart Van Assche
2019-05-31 9:03 ` Paolo Bonzini
2019-07-05 7:52 ` Hannes Reinecke
2019-07-08 9:47 ` Ming Lei
2019-06-10 12:36 ` [PATCH 0/2] scsi: add support for " Stefan Hajnoczi
2019-06-26 13:51 ` Paolo Bonzini
2019-06-26 14:14 ` Douglas Gilbert
2019-06-26 14:50 ` Paolo Bonzini
2019-06-27 3:37 ` Martin K. Petersen
2019-06-27 8:17 ` Paolo Bonzini
2019-07-05 7:13 ` Hannes Reinecke
2019-07-05 11:58 ` Paolo Bonzini
2019-07-12 1:37 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad0578b0-ce73-85ed-b67d-70c5d8176a23@acm.org \
--to=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).