From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 696A2C433ED for ; Mon, 3 May 2021 13:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F26B6127A for ; Mon, 3 May 2021 13:42:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234387AbhECNnl (ORCPT ); Mon, 3 May 2021 09:43:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27123 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234379AbhECNnj (ORCPT ); Mon, 3 May 2021 09:43:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620049366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jh0/hHrHbLzaHCSYuT1pc5Fh+CANKYVwkmu3cpQk8WE=; b=ZaU0qPUCoEZ589gG9GyGR90voP8o+toJN4k/YRij9j1bJtC5y482Mn+tWwC5SmvNmeQhIF 2gHAPoGDwgT7b3hHXtSrDgnD9wp0eIJfYYxWSI0ipozbsEgiXosqq6Ku8AJeAP6kRmT0BW gGx21HtIw+9VZ+kcwWy0wXiDUph7WuQ= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-33-hf9MzavZMEi_IQEDfLdhPQ-1; Mon, 03 May 2021 09:42:44 -0400 X-MC-Unique: hf9MzavZMEi_IQEDfLdhPQ-1 Received: by mail-ed1-f69.google.com with SMTP id g19-20020a0564021813b029038811907178so4541489edy.14 for ; Mon, 03 May 2021 06:42:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jh0/hHrHbLzaHCSYuT1pc5Fh+CANKYVwkmu3cpQk8WE=; b=GEGqhMXNiJjDQGzO9Hx4PtWxnj8EkBf7qsb0IoNem2bvvDD9JDgQk1dte9BZaNHjgk NjCbB6RntpHdiUVmCcZ6UdDDu6syHKPIJq0ZNuFEdc7+LDtZvzc2Ej/jmU2ZWI5bwJRF s+FJGTARmi9ssZckyyU0z9OhLVkLURXtWUPookqD5M3I81JDT/T6o8NIp8hGi9s/6g5R U36bdEzgmpn6Q0hKuKmP9uUiy6yz/kscPyJajN5s6NY93Y1PN9n3hlGauW9Tqn5JdFYT 6CIMWN/jOTgy63g3THxeebr6LuscsV6i8xw+N68vpO72kogBdKFxkxh/f1zZTGSA6Y7r 3/LA== X-Gm-Message-State: AOAM530vmHOa6tv7jwrdnYCDT0w4+Grzd7Fe/kQLTr+IxyBlz5XIVotv wzd+mQpmv6+hRWRud1plebspmXGNPT/T3kV9cfce8EtcOB6oUoUsxH5TKPaP6RV8YL2yUKwygqU VOBqs1/+kB6x6 X-Received: by 2002:a50:ed0c:: with SMTP id j12mr20095440eds.12.1620049363350; Mon, 03 May 2021 06:42:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzT1FEL4DEzuhWsaXKj6xN8HE6TDqjHPEBH/r40+4+mMkvdP67JaLFWtCoHZkMx52g29PwGSw== X-Received: by 2002:a50:ed0c:: with SMTP id j12mr20095421eds.12.1620049363215; Mon, 03 May 2021 06:42:43 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id q16sm12725801edv.61.2021.05.03.06.42.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 May 2021 06:42:42 -0700 (PDT) To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Peter Xu , Sean Christopherson , Peter Shier , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong References: <20210429211833.3361994-1-bgardon@google.com> <20210429211833.3361994-8-bgardon@google.com> From: Paolo Bonzini Subject: Re: [PATCH v2 7/7] KVM: x86/mmu: Lazily allocate memslot rmaps Message-ID: Date: Mon, 3 May 2021 15:42:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210429211833.3361994-8-bgardon@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 29/04/21 23:18, Ben Gardon wrote: > +int alloc_memslots_rmaps(struct kvm *kvm, struct kvm_memslots *slots) This can be static, can't it? Paolo > +{ > + struct kvm_memory_slot *slot; > + int r = 0; > + > + kvm_for_each_memslot(slot, slots) { > + r = alloc_memslot_rmap(kvm, slot, slot->npages); > + if (r) > + break; > + } > + return r; > +} > +