From: David Woodhouse <dwmw2@infradead.org>
To: Paul Durrant <paul@xen.org>, Paolo Bonzini <pbonzini@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
Sean Christopherson <seanjc@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Shuah Khan <shuah@kernel.org>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v10 16/19] KVM: xen: split up kvm_xen_set_evtchn_fast()
Date: Thu, 14 Dec 2023 14:20:27 +0000 [thread overview]
Message-ID: <ad800a830dab3cdefc28e30aa0b59fa5b4ba0211.camel@infradead.org> (raw)
In-Reply-To: <e22e354305d853d72039c7e12b166410de3f63c9.camel@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 678 bytes --]
On Thu, 2023-12-14 at 14:00 +0000, David Woodhouse wrote:
>
> > + if (IS_ENABLED(CONFIG_64BIT) && kvm->arch.xen.long_mode) {
> > + struct vcpu_info *vcpu_info = gpc->khva;
> > + u32 port_word_bit = port / 32;
>
> Shouldn't that one be /64, and the compat one be /32?
I think the reason the test failed to spot this for you is because...
#define EVTCHN_TEST1 15
#define EVTCHN_TEST2 66
#define EVTCHN_TIMER 13
... it doesn't actually use any port numbers where the bit# differs for
32-bit vs. 64-bit.
If you change EVTCHN_TIMER to something like 50, I bet it'll fail (as
it should).
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
next prev parent reply other threads:[~2023-12-14 14:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 14:43 [PATCH v10 00/19] KVM: xen: update shared_info and vcpu_info handling Paul Durrant
2023-12-04 14:43 ` [PATCH v10 01/19] KVM: pfncache: Add a map helper function Paul Durrant
2023-12-04 14:43 ` [PATCH v10 02/19] KVM: pfncache: remove unnecessary exports Paul Durrant
2023-12-04 14:43 ` [PATCH v10 03/19] KVM: xen: mark guest pages dirty with the pfncache lock held Paul Durrant
2023-12-04 14:43 ` [PATCH v10 04/19] KVM: pfncache: add a mark-dirty helper Paul Durrant
2023-12-04 14:43 ` [PATCH v10 05/19] KVM: pfncache: remove KVM_GUEST_USES_PFN usage Paul Durrant
2023-12-04 14:43 ` [PATCH v10 06/19] KVM: pfncache: stop open-coding offset_in_page() Paul Durrant
2023-12-04 14:43 ` [PATCH v10 07/19] KVM: pfncache: include page offset in uhva and use it consistently Paul Durrant
2023-12-04 14:43 ` [PATCH v10 08/19] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA Paul Durrant
2023-12-04 14:43 ` [PATCH v10 09/19] KVM: xen: separate initialization of shared_info cache and content Paul Durrant
2023-12-14 13:41 ` David Woodhouse
2023-12-14 14:00 ` Paul Durrant
2023-12-04 14:43 ` [PATCH v10 10/19] KVM: xen: (re-)initialize shared_info if guest (32/64-bit) mode is set Paul Durrant
2023-12-14 13:44 ` David Woodhouse
2023-12-04 14:43 ` [PATCH v10 11/19] KVM: xen: allow shared_info to be mapped by fixed HVA Paul Durrant
2023-12-04 14:43 ` [PATCH v10 12/19] KVM: xen: allow vcpu_info " Paul Durrant
2023-12-04 14:43 ` [PATCH v10 13/19] KVM: selftests / xen: map shared_info using HVA rather than GFN Paul Durrant
2023-12-04 14:43 ` [PATCH v10 14/19] KVM: selftests / xen: re-map vcpu_info using HVA rather than GPA Paul Durrant
2023-12-04 14:43 ` [PATCH v10 15/19] KVM: xen: advertize the KVM_XEN_HVM_CONFIG_SHARED_INFO_HVA capability Paul Durrant
2023-12-04 14:43 ` [PATCH v10 16/19] KVM: xen: split up kvm_xen_set_evtchn_fast() Paul Durrant
2023-12-14 14:00 ` David Woodhouse
2023-12-14 14:20 ` David Woodhouse [this message]
2023-12-04 14:43 ` [PATCH v10 17/19] KVM: xen: don't block on pfncache locks in kvm_xen_set_evtchn_fast() Paul Durrant
2023-12-14 14:03 ` David Woodhouse
2023-12-04 14:43 ` [PATCH v10 18/19] KVM: pfncache: check the need for invalidation under read lock first Paul Durrant
2023-12-14 14:08 ` David Woodhouse
2023-12-04 14:43 ` [PATCH v10 19/19] KVM: xen: allow vcpu_info content to be 'safely' copied Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad800a830dab3cdefc28e30aa0b59fa5b4ba0211.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).