From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 439C2C433EF for ; Fri, 14 Jan 2022 12:31:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241088AbiANMb3 (ORCPT ); Fri, 14 Jan 2022 07:31:29 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:28178 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241079AbiANMbX (ORCPT ); Fri, 14 Jan 2022 07:31:23 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20E9rVwu017438; Fri, 14 Jan 2022 12:29:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=hwlL8jG1miQ/OC88rOTP9Qxe5Y+51cvIZUDsR3IpE5w=; b=Jste4pqlTbYf6T1NsUQx6bqM/+1YpYtV0FDUbfzH5ruuXHUnqAGMo0p1sh+xBw/WcZG8 XvUQtGQEXnqcX0LfZH0oxRb9MCwtZYb5fnT5snLmjjUpM+kMdVN9SRZ1eMYlMG/gdMYd 97Ul4cWwpWtU2rOxBsZaWgdtUsM9A4LtT1JVRzV947usqjb5vEdvim5jMVH4bEAbU2b6 XIb+GHpLzb+0zidUPOmXhGmUqtYCM0GK1fhF0GWZ60fS7u1giGFCTvWjjPnR/ynoBSox Ddf7tBEtubHDhEIuaD/KvjXnspsOP6Ldnzv9gBE2uNFTWfTUpSOZdKVsgl44McIITiBA jw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3dk6xmjjh6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Jan 2022 12:29:54 +0000 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 20ECTsx1015997; Fri, 14 Jan 2022 12:29:54 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 3dk6xmjjg9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Jan 2022 12:29:54 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 20ECSHZR023672; Fri, 14 Jan 2022 12:29:51 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma04ams.nl.ibm.com with ESMTP id 3df289x63y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Jan 2022 12:29:51 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 20ECKfw942926492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 14 Jan 2022 12:20:41 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9B81252050; Fri, 14 Jan 2022 12:29:48 +0000 (GMT) Received: from [9.171.88.24] (unknown [9.171.88.24]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 16F815205F; Fri, 14 Jan 2022 12:29:47 +0000 (GMT) Message-ID: Date: Fri, 14 Jan 2022 13:29:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 0/5] kvm: fix latent guest entry/exit bugs Content-Language: en-US To: Mark Rutland Cc: linux-kernel@vger.kernel.org, aleksandar.qemu.devel@gmail.com, alexandru.elisei@arm.com, anup.patel@wdc.com, aou@eecs.berkeley.edu, atish.patra@wdc.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, chenhuacai@kernel.org, dave.hansen@linux.intel.com, david@redhat.com, frankja@linux.ibm.com, frederic@kernel.org, gor@linux.ibm.com, hca@linux.ibm.com, imbrenda@linux.ibm.com, james.morse@arm.com, jmattson@google.com, joro@8bytes.org, kvm@vger.kernel.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, nsaenzju@redhat.com, palmer@dabbelt.com, paulmck@kernel.org, paulus@samba.org, paul.walmsley@sifive.com, pbonzini@redhat.com, seanjc@google.com, suzuki.poulose@arm.com, tglx@linutronix.de, tsbogend@alpha.franken.de, vkuznets@redhat.com, wanpengli@tencent.com, will@kernel.org References: <20220111153539.2532246-1-mark.rutland@arm.com> <127a6117-85fb-7477-983c-daf09e91349d@linux.ibm.com> From: Christian Borntraeger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Bj2hvrjmwb5h9G5dh_Zi7SnpgHktSNnX X-Proofpoint-ORIG-GUID: wWmUB7R1oI4hWbROxbgfEJAUI7-yV8fR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-14_04,2022-01-14_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 mlxlogscore=721 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201140081 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Am 14.01.22 um 13:19 schrieb Mark Rutland: > On Thu, Jan 13, 2022 at 04:20:07PM +0100, Christian Borntraeger wrote: >> >> >> Am 11.01.22 um 16:35 schrieb Mark Rutland: >>> Several architectures have latent bugs around guest entry/exit, most >>> notably: >>> >>> 1) Several architectures enable interrupts between guest_enter() and >>> guest_exit(). As this period is an RCU extended quiescent state (EQS) this >>> is unsound unless the irq entry code explicitly wakes RCU, which most >>> architectures only do for entry from usersapce or idle. >>> >>> I believe this affects: arm64, riscv, s390 >>> >>> I am not sure about powerpc. >>> >>> 2) Several architectures permit instrumentation of code between >>> guest_enter() and guest_exit(), e.g. KASAN, KCOV, KCSAN, etc. As >>> instrumentation may directly o indirectly use RCU, this has the same >>> problems as with interrupts. >>> >>> I believe this affects: arm64, mips, powerpc, riscv, s390 >>> >>> 3) Several architectures do not inform lockdep and tracing that >>> interrupts are enabled during the execution of the guest, or do so in >>> an incorrect order. Generally >>> this means that logs will report IRQs being masked for much longer >>> than is actually the case, which is not ideal for debugging. I don't >>> know whether this affects the correctness of lockdep. >>> >>> I believe this affects: arm64, mips, powerpc, riscv, s390 >>> >>> This was previously fixed for x86 specifically in a series of commits: >>> >>> 87fa7f3e98a1310e ("x86/kvm: Move context tracking where it belongs") >>> 0642391e2139a2c1 ("x86/kvm/vmx: Add hardirq tracing to guest enter/exit") >>> 9fc975e9efd03e57 ("x86/kvm/svm: Add hardirq tracing on guest enter/exit") >>> 3ebccdf373c21d86 ("x86/kvm/vmx: Move guest enter/exit into .noinstr.text") >>> 135961e0a7d555fc ("x86/kvm/svm: Move guest enter/exit into .noinstr.text") >>> 160457140187c5fb ("KVM: x86: Defer vtime accounting 'til after IRQ handling") >>> bc908e091b326467 ("KVM: x86: Consolidate guest enter/exit logic to common helpers") >>> >>> But other architectures were left broken, and the infrastructure for >>> handling this correctly is x86-specific. >>> >>> This series introduces generic helper functions which can be used to >>> handle the problems above, and migrates architectures over to these, >>> fixing the latent issues. >>> >>> I wasn't able to figure my way around powerpc and s390, so I have not >> >> I think 2 later patches have moved the guest_enter/exit a bit out. >> Does this make the s390 code clearer? > > Yes; that's much simpler to follow! > > One major thing I wasn't sure about for s390 is the sequence: > > guest_enter_irqoff(); // Enters an RCU EQS > ... > local_irq_enable(); > ... > sie64a(...); > ... > local_irq_disable(); > ... > guest_exit_irqoff(); // Exits an RCU EQS > > ... since if an IRQ is taken between local_irq_{enable,disable}(), RCU won't be > watching, and I couldn't spot whether your regular IRQ entry logic would wake > RCU in this case, or whether there was something else I'm missing that saves > you here. > > For other architectures, including x86 and arm64, we enter the guest with IRQs > masked and return from the guest with IRQs masked, and don't actually take IRQs > until we unmask them in the host, after the guest_exit_*() logic has woken RCU > and so on. > > I wasn't able to find documentation on the semantics of SIE, so I couldn't spot > whether the local_irq_{enable,disable}() calls were necessary, or could be > removed. We run the SIE instruction with interrupts enabled. SIE is interruptible. The disable/enable pairs are just because guest_enter/exit_irqoff() require them. One thing to be aware of: in our entry.S - after an interrupt - we leave SIE by setting the return address of the interrupt after the sie instruction so that we get back into this __vcpu_run loop to check for signals and so. > > Thanks, > Mark. > >> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c >> index 577f1ead6a51..5859207c2cc0 100644 >> --- a/arch/s390/kvm/kvm-s390.c >> +++ b/arch/s390/kvm/kvm-s390.c >> @@ -4145,10 +4145,6 @@ static int __vcpu_run(struct kvm_vcpu *vcpu) >> * As PF_VCPU will be used in fault handler, between >> * guest_enter and guest_exit should be no uaccess. >> */ >> - local_irq_disable(); >> - guest_enter_irqoff(); >> - __disable_cpu_timer_accounting(vcpu); >> - local_irq_enable(); >> if (kvm_s390_pv_cpu_is_protected(vcpu)) { >> memcpy(sie_page->pv_grregs, >> vcpu->run->s.regs.gprs, >> @@ -4156,8 +4152,16 @@ static int __vcpu_run(struct kvm_vcpu *vcpu) >> } >> if (test_cpu_flag(CIF_FPU)) >> load_fpu_regs(); >> + local_irq_disable(); >> + __disable_cpu_timer_accounting(vcpu); >> + guest_enter_irqoff(); >> + local_irq_enable(); >> exit_reason = sie64a(vcpu->arch.sie_block, >> vcpu->run->s.regs.gprs); >> + local_irq_disable(); >> + guest_exit_irqoff(); >> + __enable_cpu_timer_accounting(vcpu); >> + local_irq_enable(); >> if (kvm_s390_pv_cpu_is_protected(vcpu)) { >> memcpy(vcpu->run->s.regs.gprs, >> sie_page->pv_grregs, >> @@ -4173,10 +4177,6 @@ static int __vcpu_run(struct kvm_vcpu *vcpu) >> vcpu->arch.sie_block->gpsw.mask &= ~PSW_INT_MASK; >> } >> } >> - local_irq_disable(); >> - __enable_cpu_timer_accounting(vcpu); >> - guest_exit_irqoff(); >> - local_irq_enable(); >> vcpu->srcu_idx = srcu_read_lock(&vcpu->kvm->srcu); >> rc = vcpu_post_run(vcpu, exit_reason);