From: Zhu Lingshan <lingshan.zhu@linux.intel.com>
To: Jason Wang <jasowang@redhat.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
mst@redhat.com, lulu@redhat.com, leonro@nvidia.com
Cc: virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA
Date: Thu, 15 Apr 2021 15:23:38 +0800 [thread overview]
Message-ID: <af2bb5e6-e690-1aa6-4be3-75a18750aeb4@linux.intel.com> (raw)
In-Reply-To: <d6b27f59-ff17-1d63-0065-fd03ee36cd2d@redhat.com>
On 4/15/2021 3:17 PM, Jason Wang wrote:
>
> 在 2021/4/15 下午2:41, Zhu Lingshan 写道:
>>>>>
>>>>> I think we've discussed this sometime in the past but what's the
>>>>> reason for such whitelist consider there's already a
>>>>> get_features() implemention?
>>>>>
>>>>> E.g Any reason to block VIRTIO_BLK_F_WRITE_ZEROS or
>>>>> VIRTIO_F_RING_PACKED?
>>>>>
>>>>> Thanks
>>>> The reason is some feature bits are supported in the device but not
>>>> supported by the driver, e.g, for virtio-net, mq & cq
>>>> implementation is not ready in the driver.
>>>
>>>
>>> I understand the case of virtio-net but I wonder why we need this
>>> for block where we don't vq cvq.
>>>
>>> Thanks
>> This is still a subset of the feature bits read from hardware, I
>> leave it here to code consistently, and indicate what we support
>> clearly.
>> Are you suggesting remove this feature bits list and just use what we
>> read from hardware?
>>
>> Thansk
>
>
> Yes, please do that.
>
> The whiltelist doesn't help in this case I think.
OK, will remove this in V2
Thanks
>
> Thanks
next prev parent reply other threads:[~2021-04-15 7:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 9:18 [PATCH 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-blk Zhu Lingshan
2021-04-14 9:18 ` [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe Zhu Lingshan
2021-04-15 3:30 ` Jason Wang
2021-04-15 5:52 ` Zhu Lingshan
2021-04-15 6:30 ` Jason Wang
2021-04-15 6:36 ` Zhu Lingshan
2021-04-15 7:16 ` Jason Wang
2021-04-15 7:23 ` Zhu Lingshan
2021-04-14 9:18 ` [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA Zhu Lingshan
2021-04-15 3:34 ` Jason Wang
2021-04-15 5:55 ` Zhu Lingshan
2021-04-15 6:31 ` Jason Wang
2021-04-15 6:41 ` Zhu Lingshan
2021-04-15 7:17 ` Jason Wang
2021-04-15 7:23 ` Zhu Lingshan [this message]
2021-04-14 9:18 ` [PATCH 3/3] vDPA/ifcvf: get_config_size should return dev specific config size Zhu Lingshan
2021-04-15 3:36 ` Jason Wang
2021-04-15 8:12 ` Stefano Garzarella
2021-04-15 8:16 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af2bb5e6-e690-1aa6-4be3-75a18750aeb4@linux.intel.com \
--to=lingshan.zhu@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).