From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65EE6C433FF for ; Wed, 31 Jul 2019 12:58:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43C7D217D7 for ; Wed, 31 Jul 2019 12:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727841AbfGaM61 (ORCPT ); Wed, 31 Jul 2019 08:58:27 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37541 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728027AbfGaM60 (ORCPT ); Wed, 31 Jul 2019 08:58:26 -0400 Received: by mail-wr1-f68.google.com with SMTP id n9so44503792wrr.4 for ; Wed, 31 Jul 2019 05:58:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5fP2qCBEwihSuFPG1uN/AQ6+YLyq3LrKayldIArWOpA=; b=BuTELiIinysGxBmbRW5i9O0Dp/dzSEkEemnYoCyNaGu83gn0wObwBHgHITeMyO/n2O vuN6fL7vHnwQtPJB24E1IVhSWNkwxFYg2ObqdhQdCrTSz1Lwez0cuQb8Jqo3wxlhxFtI ze8IPv/gjnZbaZ0ik/3M+UtrQ8cIIdC/JED++xxbsr1dZQccclh0u5ZxG5ickMTYXogD GyRmGgdGnjKQZU+WCLk8FzaSKj2IUqnJcrRsamFmnPc9m04gJvrUgQsEdRxGsOBgQIVv m/JgY2fO+olC1oMsyYCt/ZmUCBM+uuCqzrsyp62QBngzkQWS9lhDhqrLDm2b6N+FswO7 H8+A== X-Gm-Message-State: APjAAAWr26HeiKXrjGntwXn+7yeeJ34hrSbyPKIBeLuWd94YM47WRjg4 OdDqFomQHcF2iShSGaSQhlhbkQ== X-Google-Smtp-Source: APXvYqw1s7YQ7Musw4tNdkwIb4qMQbr7VmKUKXvia/n7SbLvxes86b9xZXW+ODrBjEijk/QTUhcq2w== X-Received: by 2002:adf:de90:: with SMTP id w16mr37579726wrl.217.1564577905024; Wed, 31 Jul 2019 05:58:25 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:91e7:65e:d8cd:fdb3? ([2001:b07:6468:f312:91e7:65e:d8cd:fdb3]) by smtp.gmail.com with ESMTPSA id g12sm100117916wrv.9.2019.07.31.05.58.23 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jul 2019 05:58:24 -0700 (PDT) Subject: Re: [PATCH 2/2] KVM: selftests: Enable dirty_log_test on s390x To: Thomas Huth , Andrew Jones Cc: kvm@vger.kernel.org, Christian Borntraeger , Janosch Frank , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, David Hildenbrand , Cornelia Huck , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Shuah Khan , Peter Xu References: <20190730100112.18205-1-thuth@redhat.com> <20190730100112.18205-3-thuth@redhat.com> <20190730105721.z4zsul7uxl2igoue@kamzik.brq.redhat.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: Date: Wed, 31 Jul 2019 14:58:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 31/07/19 10:19, Thomas Huth wrote: >>> @@ -293,6 +341,10 @@ static void run_test(enum vm_guest_mode mode, unsigned long iterations, >>> * case where the size is not aligned to 64 pages. >>> */ >>> guest_num_pages = (1ul << (30 - guest_page_shift)) + 16; >>> +#ifdef __s390x__ >>> + /* Round up to multiple of 1M (segment size) */ >>> + guest_num_pages = (guest_num_pages + 0xff) & ~0xffUL; >> We could maybe do this for all architectures as well. > It's really only needed on s390x, so I think we should keep the #ifdef here. Yes, on non-s390 we should keep covering the case where the size is not a multiple of BITS_PER_LONG. Paolo