From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH v3 08/18] baycom_epp: Replace rdtscl() with native_read_tsc() Date: Sat, 20 Jun 2015 18:30:52 +0200 (CEST) Message-ID: References: <1195ce0c7f34169ff3006341b77806184a46b9bf.1434501121.git.luto@kernel.org> <55857078.8060504@bfs.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: walter harms , Andy Lutomirski , X86 ML , Borislav Petkov , Peter Zijlstra , John Stultz , "linux-kernel@vger.kernel.org" , Len Brown , Huang Rui , Denys Vlasenko , kvm list , Ralf Baechle , Thomas Sailer , linux-hams@vger.kernel.org To: Andy Lutomirski Return-path: In-Reply-To: Sender: linux-hams-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Sat, 20 Jun 2015, Andy Lutomirski wrote: > On Sat, Jun 20, 2015 at 7:14 AM, Thomas Gleixner wrote: > > On Sat, 20 Jun 2015, walter harms wrote: > > > >> Acked-by: walter harms > >> > >> Am 17.06.2015 02:35, schrieb Andy Lutomirski: > >> > This is only used if BAYCOM_DEBUG is defined. > > > > So why don't we just replace that by ktime_get() and get rid of the > > x86'ism in that driver. > > > > I don't have the hardware, and I don't see any good reason to make an > rdtsc cleanup depend on a more complicated driver change. On the > other hand, if the maintainers want to clean it up, I think it would > be a great idea. > > This really seems to be debugging code, though. A normal kernel won't > even compile it. Right, but there is no reason that we have rdtsc outside of arch/x86 at all. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-hams" in