Re: [PATCH v3 10/11] mm: x86: Invoke hypercall when page encryption status is changed

From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@suse.de>
Cc: "Singh, Brijesh" <brijesh.singh@amd.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 10/11] mm: x86: Invoke hypercall when page encryption status is changed
Date: Thu, 29 Aug 2019 20:21:33 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1908292018500.1938@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190829180717.GF2132@zn.tnic>

On Thu, 29 Aug 2019, Borislav Petkov wrote:

> On Wed, Jul 10, 2019 at 08:13:11PM +0000, Singh, Brijesh wrote:
> > @@ -2060,6 +2067,14 @@ static int __set_memory_enc_dec(unsigned long addr, int numpages, bool enc)
> >  	 */
> >  	cpa_flush(&cpa, 0);
> >  
> > +	/*
> > +	 * When SEV is active, notify hypervisor that a given memory range is mapped
> > +	 * encrypted or decrypted. Hypervisor will use this information during
> > +	 * the VM migration.
> > +	 */
> > +	if (sev_active())
> > +		set_memory_enc_dec_hypercall(addr, numpages << PAGE_SHIFT, enc);
> 
> Btw, tglx has a another valid design concern here: why isn't this a
> pv_ops thing? So that it is active only when the hypervisor is actually
> present?
> 
> I know, I know, this will run on SEV guests only because it is all
> (hopefully) behind "if (sev_active())" checks but the clean and accepted
> design is a paravirt call, I'd say.

No. sev_active() has nothing to do with guest mode. It tells whether SEV is
active or not. So yes, this calls into this function on both guest and
host. The latter is beyond pointless.

Thanks,

	tglx