On 11/19/19 8:25 AM, Vitaly Kuznetsov wrote: > Dan Carpenter writes: > >> On Tue, Nov 19, 2019 at 01:28:32PM +0100, Vitaly Kuznetsov wrote: >>> Dan Carpenter writes: >>> >>>> On Tue, Nov 19, 2019 at 12:58:54PM +0100, Vitaly Kuznetsov wrote: >>>>> Mao Wenan writes: >>>>> >>>>>> Fixes gcc '-Wunused-but-set-variable' warning: >>>>>> >>>>>> arch/x86/kvm/x86.c: In function kvm_make_scan_ioapic_request_mask: >>>>>> arch/x86/kvm/x86.c:7911:7: warning: variable called set but not >>>>>> used [-Wunused-but-set-variable] >>>>>> >>>>>> It is not used since commit 7ee30bc132c6 ("KVM: x86: deliver KVM >>>>>> IOAPIC scan request to target vCPUs") >>>>> Better expressed as >>>>> >>>>> Fixes: 7ee30bc132c6 ("KVM: x86: deliver KVM IOAPIC scan request to target vCPUs") >>>>> >>>> There is sort of a debate about this whether the Fixes tag should be >>>> used if it's only a cleanup. >>>> >>> I have to admit I'm involved in doing backporting sometimes and I really >>> appreciate Fixes: tags. Just so you know on which side of the debate I >>> am :-) >> But we're not going to backport this hopefully? >> > In case we're speaking about stable@ kernels, 7ee30bc132c6 doesn't look > like a good candidate (to me) but who knows, it may get pulled in > because of some code dependency or some other 'autosel magic'. And > that's when 'Fixes:' tags become handy. Anything I can improve upon? If required I can send fixes on top of it. For the build error, I didn't trigger it because I didn't compile with appropriate flags. I will make a note for myself for next time. Thanks, Mao for sending the fix. > -- Nitesh