kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] KVM: Fix the indentation to match coding style
@ 2020-05-18  1:31 Haiwei Li
  2020-05-18  3:00 ` Wanpeng Li
  2020-05-18 10:55 ` Paolo Bonzini
  0 siblings, 2 replies; 3+ messages in thread
From: Haiwei Li @ 2020-05-18  1:31 UTC (permalink / raw)
  To: pbonzini, Sean Christopherson, vkuznets, wanpengli, jmattson,
	joro, tglx, mingo, bp, hpa
  Cc: x86, kvm, linux-kernel

From: Haiwei Li <lihaiwei@tencent.com>

There is a bad indentation in next&queue branch. The patch looks like 
fixes nothing though it fixes the indentation.

Before fixing:

                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                         kvm_skip_emulated_instruction(vcpu);
                         ret = EXIT_FASTPATH_EXIT_HANDLED;
                }
                 break;
         case MSR_IA32_TSCDEADLINE:

After fixing:

                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                         kvm_skip_emulated_instruction(vcpu);
                         ret = EXIT_FASTPATH_EXIT_HANDLED;
                 }
                 break;
         case MSR_IA32_TSCDEADLINE:


Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
---
  arch/x86/kvm/x86.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 471fccf..446f747 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct 
kvm_vcpu *vcpu)
                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
                         kvm_skip_emulated_instruction(vcpu);
                         ret = EXIT_FASTPATH_EXIT_HANDLED;
-               }
+               }
                 break;
         case MSR_IA32_TSCDEADLINE:
                 data = kvm_read_edx_eax(vcpu);
--
1.8.3.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] KVM: Fix the indentation to match coding style
  2020-05-18  1:31 [PATCH] KVM: Fix the indentation to match coding style Haiwei Li
@ 2020-05-18  3:00 ` Wanpeng Li
  2020-05-18 10:55 ` Paolo Bonzini
  1 sibling, 0 replies; 3+ messages in thread
From: Wanpeng Li @ 2020-05-18  3:00 UTC (permalink / raw)
  To: Haiwei Li
  Cc: pbonzini, Sean Christopherson, vkuznets, Wanpeng Li, jmattson,
	joro, tglx, mingo, bp, H. Peter Anvin, x86, kvm, linux-kernel

On Mon, 18 May 2020 at 09:32, Haiwei Li <lihaiwei.kernel@gmail.com> wrote:
>
> From: Haiwei Li <lihaiwei@tencent.com>
>
> There is a bad indentation in next&queue branch. The patch looks like
> fixes nothing though it fixes the indentation.
>
> Before fixing:
>
>                  if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                          kvm_skip_emulated_instruction(vcpu);
>                          ret = EXIT_FASTPATH_EXIT_HANDLED;
>                 }
>                  break;
>          case MSR_IA32_TSCDEADLINE:
>
> After fixing:
>
>                  if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                          kvm_skip_emulated_instruction(vcpu);
>                          ret = EXIT_FASTPATH_EXIT_HANDLED;
>                  }
>                  break;
>          case MSR_IA32_TSCDEADLINE:
>

Reviewed-by: Wanpeng Li <wanpengli@tencent.com>

>
> Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
> ---
>   arch/x86/kvm/x86.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 471fccf..446f747 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
> kvm_vcpu *vcpu)
>                  if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                          kvm_skip_emulated_instruction(vcpu);
>                          ret = EXIT_FASTPATH_EXIT_HANDLED;
> -               }
> +               }
>                  break;
>          case MSR_IA32_TSCDEADLINE:
>                  data = kvm_read_edx_eax(vcpu);
> --
> 1.8.3.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] KVM: Fix the indentation to match coding style
  2020-05-18  1:31 [PATCH] KVM: Fix the indentation to match coding style Haiwei Li
  2020-05-18  3:00 ` Wanpeng Li
@ 2020-05-18 10:55 ` Paolo Bonzini
  1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-05-18 10:55 UTC (permalink / raw)
  To: Haiwei Li, Sean Christopherson, vkuznets, wanpengli, jmattson,
	joro, tglx, mingo, bp, hpa
  Cc: x86, kvm, linux-kernel

On 18/05/20 03:31, Haiwei Li wrote:
> From: Haiwei Li <lihaiwei@tencent.com>
> 
> There is a bad indentation in next&queue branch. The patch looks like
> fixes nothing though it fixes the indentation.
> 
> Before fixing:
> 
>                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                         kvm_skip_emulated_instruction(vcpu);
>                         ret = EXIT_FASTPATH_EXIT_HANDLED;
>                }
>                 break;
>         case MSR_IA32_TSCDEADLINE:
> 
> After fixing:
> 
>                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                         kvm_skip_emulated_instruction(vcpu);
>                         ret = EXIT_FASTPATH_EXIT_HANDLED;
>                 }
>                 break;
>         case MSR_IA32_TSCDEADLINE:
> 
> 
> Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
> ---
>  arch/x86/kvm/x86.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 471fccf..446f747 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1631,7 +1631,7 @@ fastpath_t handle_fastpath_set_msr_irqoff(struct
> kvm_vcpu *vcpu)
>                 if (!handle_fastpath_set_x2apic_icr_irqoff(vcpu, data)) {
>                         kvm_skip_emulated_instruction(vcpu);
>                         ret = EXIT_FASTPATH_EXIT_HANDLED;
> -               }
> +               }
>                 break;
>         case MSR_IA32_TSCDEADLINE:
>                 data = kvm_read_edx_eax(vcpu);
> -- 
> 1.8.3.1
> 

Queued, thanks.

Paolo


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-18 10:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18  1:31 [PATCH] KVM: Fix the indentation to match coding style Haiwei Li
2020-05-18  3:00 ` Wanpeng Li
2020-05-18 10:55 ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).