From: Xianting Tian <xianting.tian@linux.alibaba.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: sgarzare@redhat.com, davem@davemloft.net, kuba@kernel.org,
jasowang@redhat.com, kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] vsock/virtio: set vsock frontend ready in virtio_vsock_probe()
Date: Tue, 20 Jul 2021 19:05:39 +0800 [thread overview]
Message-ID: <b48bd02d-9514-ec0c-3779-fd5ddc5c2d3d@linux.alibaba.com> (raw)
In-Reply-To: <YPakBTVDbgVcTGQX@stefanha-x1.localdomain>
在 2021/7/20 下午6:23, Stefan Hajnoczi 写道:
> On Tue, Jul 20, 2021 at 03:13:37PM +0800, Xianting Tian wrote:
>> Add the missed virtio_device_ready() to set vsock frontend ready.
>>
>> Signed-off-by: Xianting Tian<xianting.tian@linux.alibaba.com>
>> ---
>> net/vmw_vsock/virtio_transport.c | 2 ++
>> 1 file changed, 2 insertions(+)
> Please include a changelog when you send v2, v3, etc patches.
OK, thanks.
>> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
>> index e0c2c992a..dc834b8fd 100644
>> --- a/net/vmw_vsock/virtio_transport.c
>> +++ b/net/vmw_vsock/virtio_transport.c
>> @@ -639,6 +639,8 @@ static int virtio_vsock_probe(struct virtio_device *vdev)
>>
>> mutex_unlock(&the_virtio_vsock_mutex);
>>
>> + virtio_device_ready(vdev);
> Why is this patch necessary?
Sorry, I didn't notice the check in virtio_dev_probe(),
As Jason comment, I alsoe think we need to be consistent: switch to use
virtio_device_ready() for all the drivers. What's opinion about this?
> The core virtio_dev_probe() code already calls virtio_device_ready for
> us:
>
> static int virtio_dev_probe(struct device *_d)
> {
> ...
> err = drv->probe(dev);
> if (err)
> goto err;
>
> /* If probe didn't do it, mark device DRIVER_OK ourselves. */
> if (!(dev->config->get_status(dev) & VIRTIO_CONFIG_S_DRIVER_OK))
> virtio_device_ready(dev);
next prev parent reply other threads:[~2021-07-20 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 7:13 [PATCH v2] vsock/virtio: set vsock frontend ready in virtio_vsock_probe() Xianting Tian
2021-07-20 7:54 ` Jason Wang
2021-07-20 8:36 ` Xianting Tian
2021-07-20 10:23 ` Stefan Hajnoczi
2021-07-20 10:56 ` Xianting Tian
2021-07-20 11:05 ` Xianting Tian [this message]
2021-07-20 13:12 ` Stefan Hajnoczi
2021-07-21 1:30 ` Xianting Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b48bd02d-9514-ec0c-3779-fd5ddc5c2d3d@linux.alibaba.com \
--to=xianting.tian@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).