From: Janosch Frank <frankja@linux.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>, kvm@vger.kernel.org
Cc: thuth@redhat.com, david@redhat.com, cohuck@redhat.com,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v9] KVM: s390: Add new reset vcpu API
Date: Thu, 30 Jan 2020 14:02:59 +0100 [thread overview]
Message-ID: <b52e8e3c-7366-7ac5-0fbc-beaceed977d8@linux.ibm.com> (raw)
In-Reply-To: <9dfba609-8fb4-53a1-88ed-3ed98112200c@de.ibm.com>
[-- Attachment #1.1: Type: text/plain, Size: 971 bytes --]
On 1/30/20 1:59 PM, Christian Borntraeger wrote:
>
>
> On 30.01.20 13:55, Janosch Frank wrote:
>
>> +static void kvm_arch_vcpu_ioctl_initial_reset(struct kvm_vcpu *vcpu)
>> +{
>> + /* Initial reset is a superset of the normal reset */
>> + kvm_arch_vcpu_ioctl_normal_reset(vcpu);
>> +
>> + /* this equals initial cpu reset in pop, but we don't switch to ESA */
>> + vcpu->arch.sie_block->gpsw.mask = 0;
>> + vcpu->arch.sie_block->gpsw.addr = 0;
>> + kvm_s390_set_prefix(vcpu, 0);
>> + kvm_s390_set_cpu_timer(vcpu, 0);
>> + vcpu->arch.sie_block->ckc = 0;
>> + vcpu->arch.sie_block->todpr = 0;
>> + memset(vcpu->arch.sie_block->gcr, 0, sizeof(vcpu->arch.sie_block->gcr));
>> + vcpu->arch.sie_block->gcr[0] = CR0_INITIAL_MASK;
>> + vcpu->arch.sie_block->gcr[14] = CR14_INITIAL_MASK;
>> + vcpu->run->s.regs.fpc = 0;
>
>> + current->thread.fpu.fpc = 0;
>
> This is still wrong.
Your fixpatch doesn't delete it :)
That hunk is not mine...
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-30 13:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 12:34 [PATCH v9 0/6] KVM: s390: Add new reset vcpu API Janosch Frank
2020-01-30 12:34 ` [PATCH v9 1/6] KVM: s390: do not clobber registers during guest reset/store status Janosch Frank
2020-01-30 12:39 ` David Hildenbrand
2020-01-30 13:00 ` Cornelia Huck
2020-01-30 13:02 ` Christian Borntraeger
2020-01-30 12:34 ` [PATCH v9 2/6] KVM: s390: Cleanup initial cpu reset Janosch Frank
2020-01-30 13:20 ` Thomas Huth
2020-01-30 12:34 ` [PATCH v9 3/6] KVM: s390: Add new reset vcpu API Janosch Frank
2020-01-30 12:49 ` Janosch Frank
2020-01-30 12:55 ` [PATCH v9] " Janosch Frank
2020-01-30 12:59 ` Christian Borntraeger
2020-01-30 13:02 ` Janosch Frank [this message]
2020-01-30 13:01 ` Cornelia Huck
2020-01-30 12:53 ` [PATCH v9 3/6] " Christian Borntraeger
2020-01-30 12:34 ` [PATCH v9 4/6] selftests: KVM: Add fpu and one reg set/get library functions Janosch Frank
2020-01-30 13:03 ` Cornelia Huck
2020-01-30 12:34 ` [PATCH v9 5/6] selftests: KVM: s390x: Add reset tests Janosch Frank
2020-01-30 13:25 ` Thomas Huth
2020-01-30 16:22 ` Cornelia Huck
2020-01-30 12:34 ` [PATCH v9 6/6] selftests: KVM: testing the local IRQs resets Janosch Frank
2020-01-30 16:27 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b52e8e3c-7366-7ac5-0fbc-beaceed977d8@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).