From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62D90C7EE22 for ; Sat, 6 May 2023 09:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231143AbjEFJRF (ORCPT ); Sat, 6 May 2023 05:17:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230000AbjEFJRD (ORCPT ); Sat, 6 May 2023 05:17:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CD442694 for ; Sat, 6 May 2023 02:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683364576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KsDzLFnpYpZQjeRWWOmndbUxeGH12g+kaA80++/jh18=; b=GXEBun7ij8clwJM1iZfAoObdQqi0zNwnCwT6DIHx79fD+rUvGOCLTzFk/z3TOIssx6gfb+ e2Yn3jGGDqCGP4xsNL+juYT8zOrJ0UMBjujb+OdQmpeiR1O3gxiMdPfX5oybUoPxG8iqTE 6jybKRYvHPu1fDeL50yrTNmwl2Q3NKk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-139-TBU1gD_AN3alGSIcG_Ulmw-1; Sat, 06 May 2023 05:16:08 -0400 X-MC-Unique: TBU1gD_AN3alGSIcG_Ulmw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f21e35dc08so11140985e9.2 for ; Sat, 06 May 2023 02:16:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683364567; x=1685956567; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KsDzLFnpYpZQjeRWWOmndbUxeGH12g+kaA80++/jh18=; b=kDE9N/+WGvU/11dASl+uFNx4TKPh0vkC59X4Qo7V2TLdZojlemTaUGMaH6qv2I1UK+ p8zHL/ygKM1Crjen0AJY+DdI2/zHCWDLT5mEAChctXJpsBQvKkZJVLl/6R380hE3skoG U5Y4qnH77KG++8lcEYoAZUJ2+F9dypBu+rv7fP3ja78UA1MSQHcRbQFd+s0Ua9YZFRn8 gSvZqePZe7lGZMh9ZnchZ08w5UvjqOebJuifDbOs/rwF4w+kjcEXxSqP8tZCCWTjRty2 TJKOfymgrqh4ND2kq12M3aL7JUtqAZF7DqF/eGn+mFiYAQs0CXfulN10xxQZTYS4eBXJ uBQw== X-Gm-Message-State: AC+VfDy3r1Fu/lWqoMqpIbld+VyTUnltdQdk6iTTxtuNxqHiHZn5BGV2 HOIWxWbH6ybRtrmJTVdYpBotA6zPINr4zMc0OZjwpPd9Lf7HNpb6vSYXXcJsr36Ty2OuoBfDWfh 4D2fcFeri11mk X-Received: by 2002:a7b:cc15:0:b0:3f4:16bc:bd1b with SMTP id f21-20020a7bcc15000000b003f416bcbd1bmr1058181wmh.39.1683364566885; Sat, 06 May 2023 02:16:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5yT30KCl8xFUHNvRL0GXZ37yB4LlxoA/VrJPeYY0UrtOFZLwzVNDEqFTNy9mik0LH+szXbfw== X-Received: by 2002:a7b:cc15:0:b0:3f4:16bc:bd1b with SMTP id f21-20020a7bcc15000000b003f416bcbd1bmr1058146wmh.39.1683364566395; Sat, 06 May 2023 02:16:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c72b:8c00:d06f:a47f:7155:9f1c? (p200300cbc72b8c00d06fa47f71559f1c.dip0.t-ipconnect.de. [2003:cb:c72b:8c00:d06f:a47f:7155:9f1c]) by smtp.gmail.com with ESMTPSA id x9-20020adfec09000000b002faaa9a1721sm4783661wrn.58.2023.05.06.02.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 May 2023 02:16:05 -0700 (PDT) Message-ID: Date: Sat, 6 May 2023 11:16:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: Rename restrictedmem => guardedmem? (was: Re: [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM) To: Vlastimil Babka , Jarkko Sakkinen , Sean Christopherson , Chao Peng Cc: Paolo Bonzini , Vitaly Kuznetsov , Jim Mattson , Joerg Roedel , "Maciej S . Szmigiero" , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , wei.w.wang@intel.com, Mike Rapoport , Liam Merwick , Isaku Yamahata , Ackerley Tng , kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <658018f9-581c-7786-795a-85227c712be0@redhat.com> <6db68140-0612-a7a3-2cec-c583b2ed3a61@redhat.com> <3b0ec3da-ba18-7b9f-4e84-1cc30e78aed7@suse.cz> Content-Language: en-US From: David Hildenbrand Organization: Red Hat In-Reply-To: <3b0ec3da-ba18-7b9f-4e84-1cc30e78aed7@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 06.05.23 09:44, Vlastimil Babka wrote: > On 5/5/23 22:00, David Hildenbrand wrote: >> On 23.04.23 15:28, Jarkko Sakkinen wrote: >>> On Mon Apr 17, 2023 at 6:48 PM EEST, David Hildenbrand wrote: >>>> On 17.04.23 17:40, Sean Christopherson wrote: >>>>> What do y'all think about renaming "restrictedmem" to "guardedmem"? >>>> >>>> Yeay, let's add more confusion :D >>>> >>>> If we're at renaming, I'd appreciate if we could find a terminology that >>>> does look/sound less horrible. >>>> >>>>> >>>>> I want to start referring to the code/patches by its syscall/implementation name >>>>> instead of "UPM", as "UPM" is (a) very KVM centric, (b) refers to the broader effort >>>>> and not just the non-KVM code, and (c) will likely be confusing for future reviewers >>>>> since there's nothing in the code that mentions "UPM" in any way. >>>>> >>>>> But typing out restrictedmem is quite tedious, and git grep shows that "rmem" is >>>>> already used to refer to "reserved memory". >>>>> >>>>> Renaming the syscall to "guardedmem"... >>>> >>>> restrictedmem, guardedmem, ... all fairly "suboptimal" if you'd ask me ... >>> >>> In the world of TEE's and confidential computing it is fairly common to >>> call memory areas enclaves, even outside SGX context. So in that sense >>> enclave memory would be the most correct terminology. >> >> I was also thinking along the lines of isolated_mem or imem ... >> essentially, isolated from (unprivileged) user space. >> >> ... if we still want to have a common syscall for it. > > I'm fan of the ioctl, if it has a chance of working out. Yes, me too. -- Thanks, David / dhildenb