KVM Archive on lore.kernel.org
 help / color / Atom feed
From: Alexandru Elisei <alexandru.elisei@arm.com>
To: Milan Kocian <milon@wq.cz>
Cc: kvm@vger.kernel.org, julien.thierry.kdev@gmail.com,
	will@kernel.org, jean-philippe@linaro.org,
	andre.przywara@arm.com, Anvay Virkar <anvay.virkar@arm.com>
Subject: Re: [PATCH kvmtool] virtio: Fix ordering of virt_queue__should_signal()
Date: Tue, 4 Aug 2020 13:15:24 +0100
Message-ID: <b744ab38-dc28-683c-9e73-bf413210209e@arm.com> (raw)
In-Reply-To: <20200731220547.GD7810@msc.wq.cz>

Hello Milan,

On 7/31/20 11:05 PM, Milan Kocian wrote:
> Hello,
>  
>> I *think* this also fixes the VM hang reported in [1], where several
>> processes in the guest were stuck in uninterruptible sleep. I am not
>> familiar with the block layer, but my theory is that the threads were stuck
>> in wait_for_completion_io(), from blk_execute_rq() executing a flush
>> request. It would be great if Milan could give this patch a spin and see if
>> the problem goes away. Don't know how reproducible it is though.
>>
>> [1] https://www.spinics.net/lists/kvm/msg204543.html
>>
> Okay, I will test it but it takes some time. Because I migrated to the
> qemu due this problem :-) so I need to prepare new environment. And
> because the problem happens randomly. My environment can run days/few weeks
> without this problem.

Thank you for giving this a go, much appreciated!

It's unfortunate that you had to stop using kvmtool because of the bug, hopefully
this patch fixes it.

Thanks,
Alex

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 10:14 Alexandru Elisei
2020-07-31 13:30 ` Jean-Philippe Brucker
2020-08-04 11:13   ` Alexandru Elisei
2020-07-31 22:05 ` Milan Kocian
2020-08-04 12:15   ` Alexandru Elisei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b744ab38-dc28-683c-9e73-bf413210209e@arm.com \
    --to=alexandru.elisei@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=anvay.virkar@arm.com \
    --cc=jean-philippe@linaro.org \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=milon@wq.cz \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org
	public-inbox-index kvm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git