From: Tony Krowiak <akrowiak@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, freude@linux.ibm.com,
borntraeger@de.ibm.com, cohuck@redhat.com,
mjrosato@linux.ibm.com, alex.williamson@redhat.com,
kwankhede@nvidia.com, fiuczy@linux.ibm.com,
frankja@linux.ibm.com, david@redhat.com, hca@linux.ibm.com,
gor@linux.ibm.com
Subject: Re: [PATCH v11 07/14] s390/vfio-ap: sysfs attribute to display the guest's matrix
Date: Fri, 13 Nov 2020 12:27:32 -0500 [thread overview]
Message-ID: <b96fe876-c67a-fe6c-0e3a-7b4948edeef4@linux.ibm.com> (raw)
In-Reply-To: <20201028091758.73aa77a3.pasic@linux.ibm.com>
On 10/28/20 4:17 AM, Halil Pasic wrote:
> On Thu, 22 Oct 2020 13:12:02 -0400
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>> +static ssize_t guest_matrix_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + ssize_t nchars;
>> + struct mdev_device *mdev = mdev_from_dev(dev);
>> + struct ap_matrix_mdev *matrix_mdev = mdev_get_drvdata(mdev);
>> +
>> + if (!vfio_ap_mdev_has_crycb(matrix_mdev))
>> + return -ENODEV;
> I'm wondering, would it make sense to have guest_matrix display the would
> be guest matrix when we don't have a KVM? With the filtering in
> place, the question in what guest_matrix would my (assign) matrix result
> right now if I were to hook up my vfio_ap_mdev to a guest seems a
> legitimate one.
A couple of thoughts here:
* The ENODEV informs the user that there is no guest running
which makes sense to me given this interface displays the
guest matrix. The alternative, which I considered, was to
display an empty matrix (i.e., nothing).
* This would be a pretty drastic change to the design because
the shadow_apcb - which is what is displayed via this interface - is
only updated when the guest is started and while it is running (i.e.,
hot plug of new adapters/domains). Making this change would
require changing that entire design concept which I am reluctant
to do at this point in the game.
>
>
>> +
>> + mutex_lock(&matrix_dev->lock);
>> + nchars = vfio_ap_mdev_matrix_show(&matrix_mdev->shadow_apcb, buf);
>> + mutex_unlock(&matrix_dev->lock);
>> +
>> + return nchars;
>> +}
>> +static DEVICE_ATTR_RO(guest_matrix);
next prev parent reply other threads:[~2020-11-13 17:27 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 17:11 [PATCH v11 00/14] s390/vfio-ap: dynamic configuration support Tony Krowiak
2020-10-22 17:11 ` [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset Tony Krowiak
2020-10-22 19:44 ` kernel test robot
2020-10-26 16:57 ` Tony Krowiak
2020-10-27 6:48 ` Halil Pasic
2020-10-29 23:29 ` Tony Krowiak
2020-10-30 16:13 ` Tony Krowiak
2020-10-30 17:27 ` Halil Pasic
2020-10-30 20:45 ` Tony Krowiak
2020-10-30 17:42 ` Halil Pasic
2020-10-30 20:37 ` Tony Krowiak
2020-10-31 3:43 ` Halil Pasic
2020-11-02 14:35 ` Tony Krowiak
2020-10-30 17:54 ` Halil Pasic
2020-10-30 20:53 ` Tony Krowiak
2020-10-30 21:13 ` Tony Krowiak
2020-10-30 17:56 ` Halil Pasic
2020-10-30 21:17 ` Tony Krowiak
2020-10-22 17:11 ` [PATCH v11 02/14] 390/vfio-ap: use new AP bus interface to search for queue devices Tony Krowiak
2020-10-27 7:01 ` Halil Pasic
2020-11-02 21:57 ` Tony Krowiak
2020-10-22 17:11 ` [PATCH v11 03/14] s390/vfio-ap: manage link between queue struct and matrix mdev Tony Krowiak
2020-10-27 9:33 ` Halil Pasic
2020-10-22 17:11 ` [PATCH v11 04/14] s390/zcrypt: driver callback to indicate resource in use Tony Krowiak
2020-10-27 13:01 ` Halil Pasic
2020-10-27 16:55 ` Harald Freudenberger
2020-11-13 21:30 ` Tony Krowiak
2020-11-14 0:00 ` Halil Pasic
2020-11-16 16:23 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 05/14] s390/vfio-ap: implement in-use callback for vfio_ap driver Tony Krowiak
2020-10-27 13:27 ` Halil Pasic
2020-11-13 17:14 ` Tony Krowiak
2020-11-13 23:47 ` Halil Pasic
2020-11-16 16:58 ` Tony Krowiak
2020-11-23 17:03 ` Cornelia Huck
2020-11-23 19:23 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 06/14] s390/vfio-ap: introduce shadow APCB Tony Krowiak
2020-10-28 8:11 ` Halil Pasic
2020-11-13 17:18 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 07/14] s390/vfio-ap: sysfs attribute to display the guest's matrix Tony Krowiak
2020-10-28 8:17 ` Halil Pasic
2020-11-13 17:27 ` Tony Krowiak [this message]
2020-11-13 23:12 ` Halil Pasic
2020-11-19 18:15 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device Tony Krowiak
2020-10-22 20:30 ` kernel test robot
2020-10-26 17:04 ` Tony Krowiak
2020-10-28 13:57 ` Halil Pasic
2020-11-03 22:49 ` Tony Krowiak
2020-11-04 12:52 ` Halil Pasic
2020-11-04 21:20 ` Tony Krowiak
2020-11-05 12:27 ` Halil Pasic
2020-11-13 20:36 ` Tony Krowiak
2020-11-04 13:23 ` Halil Pasic
2020-10-22 17:12 ` [PATCH v11 09/14] s390/vfio-ap: allow assignment of unavailable AP queues to mdev device Tony Krowiak
2020-10-28 15:03 ` Halil Pasic
2020-10-22 17:12 ` [PATCH v11 10/14] s390/vfio-ap: allow hot plug/unplug of AP resources using " Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 11/14] s390/zcrypt: Notify driver on config changed and scan complete callbacks Tony Krowiak
2020-10-27 17:28 ` Harald Freudenberger
2020-11-13 20:58 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 12/14] s390/vfio-ap: handle host AP config change notification Tony Krowiak
2020-10-22 21:17 ` kernel test robot
2020-10-26 17:07 ` Tony Krowiak
2020-10-26 17:21 ` Tony Krowiak
2020-11-03 9:48 ` kernel test robot
2020-11-13 21:06 ` Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 13/14] s390/vfio-ap: handle AP bus scan completed notification Tony Krowiak
2020-10-22 17:12 ` [PATCH v11 14/14] s390/vfio-ap: update docs to include dynamic config support Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96fe876-c67a-fe6c-0e3a-7b4948edeef4@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=fiuczy@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).