From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6690C433E0 for ; Fri, 12 Feb 2021 12:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C51B64E01 for ; Fri, 12 Feb 2021 12:03:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbhBLMDI (ORCPT ); Fri, 12 Feb 2021 07:03:08 -0500 Received: from foss.arm.com ([217.140.110.172]:35920 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231264AbhBLMCk (ORCPT ); Fri, 12 Feb 2021 07:02:40 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2C791063; Fri, 12 Feb 2021 04:01:54 -0800 (PST) Received: from [192.168.0.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A95883F719; Fri, 12 Feb 2021 04:01:53 -0800 (PST) Subject: Re: [PATCH kvmtool 11/21] hw/rtc: Switch to new trap handler To: Andre Przywara , Will Deacon , Julien Thierry Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Marc Zyngier References: <20201210142908.169597-1-andre.przywara@arm.com> <20201210142908.169597-12-andre.przywara@arm.com> From: Alexandru Elisei Message-ID: Date: Fri, 12 Feb 2021 12:02:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20201210142908.169597-12-andre.przywara@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Andre, On 12/10/20 2:28 PM, Andre Przywara wrote: > Now that the RTC device has a trap handler adhering to the MMIO fault > handler prototype, let's switch over to the joint registration routine. > > This allows us to get rid of the ioport shim routines. > > Signed-off-by: Andre Przywara > --- > hw/rtc.c | 21 ++------------------- > 1 file changed, 2 insertions(+), 19 deletions(-) > > diff --git a/hw/rtc.c b/hw/rtc.c > index 664d4cb0..ee4c9102 100644 > --- a/hw/rtc.c > +++ b/hw/rtc.c > @@ -120,23 +120,6 @@ static void cmos_ram_io(struct kvm_cpu *vcpu, u64 addr, u8 *data, > } > } > > -static bool cmos_ram_in(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > -{ > - cmos_ram_io(vcpu, port, data, size, false, NULL); > - return true; > -} > - > -static bool cmos_ram_out(struct ioport *ioport, struct kvm_cpu *vcpu, u16 port, void *data, int size) > -{ > - cmos_ram_io(vcpu, port, data, size, true, NULL); > - return true; > -} > - > -static struct ioport_operations cmos_ram_ioport_ops = { > - .io_out = cmos_ram_out, > - .io_in = cmos_ram_in, > -}; > - > #ifdef CONFIG_HAS_LIBFDT > static void generate_rtc_fdt_node(void *fdt, > struct device_header *dev_hdr, > @@ -169,7 +152,7 @@ int rtc__init(struct kvm *kvm) > return r; > > /* PORT 0070-007F - CMOS RAM/RTC (REAL TIME CLOCK) */ > - r = ioport__register(kvm, 0x0070, &cmos_ram_ioport_ops, 2, NULL); > + r = kvm__register_pio(kvm, 0x0070, 2, cmos_ram_io, NULL); > if (r < 0) > goto out_device; > > @@ -188,7 +171,7 @@ dev_init(rtc__init); > int rtc__exit(struct kvm *kvm) > { > /* PORT 0070-007F - CMOS RAM/RTC (REAL TIME CLOCK) */ > - ioport__unregister(kvm, 0x0070); > + kvm__deregister_pio(kvm, 0x0070); > > return 0; > } Looks good: Reviewed-by: Alexandru Elisei Thanks, Alex