From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6A0C48BE6 for ; Fri, 11 Jun 2021 10:51:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D72A5613BA for ; Fri, 11 Jun 2021 10:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231336AbhFKKxc (ORCPT ); Fri, 11 Jun 2021 06:53:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29513 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231355AbhFKKx2 (ORCPT ); Fri, 11 Jun 2021 06:53:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623408690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GeF6NSmY+RlePXJwinqUloNFNozec5u88pDu1en91rg=; b=MwvFr1lLkN7lB27omfs0zhksr416oh/pLfq53qQHsDaHhZEYkq9sL8KScepZFWBoaq36D4 /FoCUrVhf76TcvBf67PuHlDAWGKqR5NOAjIiGsd/9fFvq212eMALEl689hveaiubYGcIJO j7HznKYln4w2htEKLiU9SNrJ1LP/NFk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-ZQrA_eyzMnaPYofLr6dbRA-1; Fri, 11 Jun 2021 06:51:29 -0400 X-MC-Unique: ZQrA_eyzMnaPYofLr6dbRA-1 Received: by mail-wr1-f71.google.com with SMTP id s8-20020adff8080000b0290114e1eeb8c6so2429436wrp.23 for ; Fri, 11 Jun 2021 03:51:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GeF6NSmY+RlePXJwinqUloNFNozec5u88pDu1en91rg=; b=A9nfbgpsS9nWeTqkppRxiANkJmRXYJtrgPFy4d/wn4AEH5ppuDc9YMqaJNEHVrLd5+ AFCEa/STmX1Tg9PAe7O/Q+bXr5DgUSjAtIPa+R8qLr3/DvNf64mnpP9P1FQlTM1OwYyA FFfAaWhym3YvqvhkJBqi6KRLdrpjLv4DCjEyQR7TKtt9UdnNVwL0c9OiJVIFlISXEfkw VHB5OKX1ZVfZA+6hXxBL7lFz1VpIIrxzvE9FIe1nw0CpV/lNgODYn/mtmxSBbEmiL/LQ pUYgJhxnb1tqmxk4ASvSwXk/MmZ0PcZw0v5X8j1C4L72ns3UtpP5rVvlexlZQwOusQl9 Jo9g== X-Gm-Message-State: AOAM531wmI8NxghSlDTvQX/kFwC9KVkK8hW6lhkiNbh1baN/sNqDbFMa RbrLQscTrk5Lf0q9CGBg9IYeOi24X43kSpHF8f0a8Y5bdty7BHH1TYj7YCc4NruuHLTcL9IN5z1 pVMUQoQPrAUjI X-Received: by 2002:a5d:6c6d:: with SMTP id r13mr3313589wrz.350.1623408688073; Fri, 11 Jun 2021 03:51:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwkNd9ko6ID8OBZPsEJA+MAlG7UkZ9Guko+3nwZmFCnop+c0VjyxH8jWHme4xipbMFJRZnG/w== X-Received: by 2002:a5d:6c6d:: with SMTP id r13mr3313547wrz.350.1623408687852; Fri, 11 Jun 2021 03:51:27 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id h9sm12694249wmm.33.2021.06.11.03.51.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jun 2021 03:51:27 -0700 (PDT) To: Christian Borntraeger , Jing Zhang , KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan References: <20210603211426.790093-1-jingzhangos@google.com> <20210603211426.790093-2-jingzhangos@google.com> <03f3fa03-6f61-7864-4867-3dc332a9d6f3@de.ibm.com> From: Paolo Bonzini Subject: Re: [PATCH v7 1/4] KVM: stats: Separate generic stats from architecture specific ones Message-ID: Date: Fri, 11 Jun 2021 12:51:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <03f3fa03-6f61-7864-4867-3dc332a9d6f3@de.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 11/06/21 08:57, Christian Borntraeger wrote: >> @@ -755,12 +750,12 @@ struct kvm_vcpu_arch { >>   }; >>   struct kvm_vm_stat { >> +    struct kvm_vm_stat_generic generic; > > s390 does not have remote_tlb_flush. I guess this does not hurt? It would have to be accounted in gmap_flush_tlb, but there is no struct kvm in there. A slightly hackish possibility would be to include the gmap by value (instead of by pointer) in struct kvm, and then use container_of. This reminds me that I have never asked you why the gmap code is not in arch/s390/kvm, and also that there is no code in QEMU that uses KVM_VM_S390_UCONTROL or KVM_S390_VCPU_FAULT. It would be nice to have some testcases for that, and also for KVM_S390_VCPU_FAULT with regular virtual machines... or to remove the code if it's unused. Thanks, Paolo