From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6542FC07E9E for ; Tue, 6 Jul 2021 12:12:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F855621F3 for ; Tue, 6 Jul 2021 12:12:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244974AbhGFMO1 (ORCPT ); Tue, 6 Jul 2021 08:14:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21386 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242403AbhGFMCe (ORCPT ); Tue, 6 Jul 2021 08:02:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625572795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uW+E9jScNZ5agh1jL2MsJyyJ0npRr318JrpawlDgYKM=; b=GF1mC7uCBZnNzh96WqufvL/F+t/2rhzn82Y2RIz0hLnxzaSO7lFYSnkL7YMziy6EWJ5PVT Y7AFqTP0ZmXGs0rxbo1ayMccKaBOjcRy39/a+eqX4PyxVo/HJG6eCpwGrR8IbeVTY8hSir FNsQB59tlOvtu7kvQ+yChFkUf8H709o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-eRFmvE44MBGIevnv1ShbdA-1; Tue, 06 Jul 2021 07:59:54 -0400 X-MC-Unique: eRFmvE44MBGIevnv1ShbdA-1 Received: by mail-wm1-f72.google.com with SMTP id j141-20020a1c23930000b0290212502cb19aso348479wmj.0 for ; Tue, 06 Jul 2021 04:59:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=uW+E9jScNZ5agh1jL2MsJyyJ0npRr318JrpawlDgYKM=; b=hhegiHsjtwcpObDZ1iRKFdkQ8Kpg1ywJrCVsdwOzPeFk2LqAUijDM9vQGOfh3x+rPE JhKZqA0wd6lcAMKEyEMXz86kwylyQgS2oawN87nC/9eBeqGEeQUkwL2AEqQn6GXggSVo bmuKYwhvE5eHwZBxdcRULeC5etuCwujJr4dXGSc5g4Cih548jR1ygDmTcHtgc43hdnqX 9nyWWesWssDUMHQeTg7afdEKwgwrfbDZWkBG+GOfx2gnmUAiHvmTQFWy/41T0MveGgqs TFajHP+Ondb9ljl1MyuQzC/R0M3Xj2OzY/u3BIH9TrrCM4uo8lDAKPzCxGUKKw2JvGcq nCbQ== X-Gm-Message-State: AOAM533OwCbpMKoJDO+6Tfc23Et7OnKntpt0rnLnBprCPoFIL3VgfHX9 jG6spoXtrcCDpC9YORJ7/7olu0h+kO+rX1dCYHUYEZhe6hLdalt3K2a+vxRXq5uWzwPJjufO1H1 /6IKV/+x38FCp X-Received: by 2002:a5d:69c9:: with SMTP id s9mr21254994wrw.155.1625572793085; Tue, 06 Jul 2021 04:59:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2u4QcVp8Z//R1GNAmE7RUOVZhrVIPxFfJvCNi9/yctbFPEoASdoc9aUnMXgr/0BSKnUccmw== X-Received: by 2002:a5d:69c9:: with SMTP id s9mr21254984wrw.155.1625572792939; Tue, 06 Jul 2021 04:59:52 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id h13sm5700227wrs.68.2021.07.06.04.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jul 2021 04:59:52 -0700 (PDT) Subject: Re: [PATCH] KVM: s390: Enable specification exception interpretation To: Christian Borntraeger , Cornelia Huck , Janis Schoetterl-Glausch , Janosch Frank , Heiko Carstens , Vasily Gorbik Cc: Claudio Imbrenda , "open list:KERNEL VIRTUAL MACHINE for s390 (KVM/s390)" , "open list:S390" , open list References: <20210706114714.3936825-1-scgl@linux.ibm.com> <87k0m3hd7h.fsf@redhat.com> <194128c1-8886-5b8b-2249-5ec58b8e7adb@de.ibm.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Tue, 6 Jul 2021 13:59:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <194128c1-8886-5b8b-2249-5ec58b8e7adb@de.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 06.07.21 13:56, Christian Borntraeger wrote: > > > On 06.07.21 13:52, Cornelia Huck wrote: >> On Tue, Jul 06 2021, Janis Schoetterl-Glausch wrote: >> >>> When this feature is enabled the hardware is free to interpret >>> specification exceptions generated by the guest, instead of causing >>> program interruption interceptions. >>> >>> This benefits (test) programs that generate a lot of specification >>> exceptions (roughly 4x increase in exceptions/sec). >>> >>> Interceptions will occur as before if ICTL_PINT is set, >>> i.e. if guest debug is enabled. >>> >>> Signed-off-by: Janis Schoetterl-Glausch >>> --- >>> I'll additionally send kvm-unit-tests for testing this feature. >>> >>> arch/s390/include/asm/kvm_host.h | 1 + >>> arch/s390/kvm/kvm-s390.c | 2 ++ >>> arch/s390/kvm/vsie.c | 2 ++ >>> 3 files changed, 5 insertions(+) >> >> (...) >> >>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c >>> index b655a7d82bf0..aadd589a3755 100644 >>> --- a/arch/s390/kvm/kvm-s390.c >>> +++ b/arch/s390/kvm/kvm-s390.c >>> @@ -3200,6 +3200,8 @@ static int kvm_s390_vcpu_setup(struct kvm_vcpu *vcpu) >>> vcpu->arch.sie_block->ecb |= ECB_SRSI; >>> if (test_kvm_facility(vcpu->kvm, 73)) >>> vcpu->arch.sie_block->ecb |= ECB_TE; >>> + if (!kvm_is_ucontrol(vcpu->kvm)) >>> + vcpu->arch.sie_block->ecb |= ECB_SPECI; >> >> Does this exist for any hardware version (i.e. not guarded by a cpu >> feature?) > > Not for all hardware versions, but also no indication. The architecture > says that the HW is free to do this or not. (which makes the vsie code > simpler). I remember the architecture said at some point to never set undefined bits - and this bit is undefined on older HW generations. I might be wrong, though. (I though HW learned the lesson to always use proper feature indications along with new features) -- Thanks, David / dhildenb