kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arseny Krasnov <arseny.krasnov@kaspersky.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jorgen Hansen <jhansen@vmware.com>,
	Colin Ian King <colin.king@canonical.com>,
	Andra Paraschiv <andraprs@amazon.com>,
	Norbert Slusarek <nslusarek@gmx.net>,
	Alexander Popov <alex.popov@linux.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stsp2@yandex.ru" <stsp2@yandex.ru>,
	"oxffffaa@gmail.com" <oxffffaa@gmail.com>
Subject: Re: [RFC PATCH v8 00/19] virtio/vsock: introduce SOCK_SEQPACKET support
Date: Thu, 22 Apr 2021 12:40:17 +0300	[thread overview]
Message-ID: <bfefdd94-a84f-8bed-331e-274654a7426f@kaspersky.com> (raw)
In-Reply-To: <20210422084638.bvblk33b4oi6cec6@steredhat>


On 22.04.2021 11:46, Stefano Garzarella wrote:
> On Wed, Apr 21, 2021 at 06:06:28PM +0300, Arseny Krasnov wrote:
>> On 21.04.2021 12:52, Stefano Garzarella wrote:
>>> On Tue, Apr 13, 2021 at 03:39:51PM +0300, Arseny Krasnov wrote:
>>>> v7 -> v8:
>>>> General changelog:
>>>> - whole idea is simplified: channel now considered reliable,
>>>>   so SEQ_BEGIN, SEQ_END, 'msg_len' and 'msg_id' were removed.
>>>>   Only thing that is used to mark end of message is bit in
>>>>   'flags' field of packet header: VIRTIO_VSOCK_SEQ_EOR. Packet
>>>>   with such bit set to 1 means, that this is last packet of
>>>>   message.
>>>>
>>>> - POSIX MSG_EOR support is removed, as there is no exact
>>>>   description how it works.
>>> It would be nice to support it, I'll try to see if I can find anything.
>>>
>>> I just reviewed the series. I think the most important things to fix are
>>> the `seqpacket_allow` stored in the struct virtio_transport that is
>>> wrong IMHO, and use cpu_to_le32()/le32_to_cpu() to access the flags.
>> Thank You, i'll prepare next version. Main question is: does this
>> approach(no SEQ_BEGIN, SEQ_END, 'msg_len' and 'msg_id') considered
>> good? In this case it will be easier to prepare final version, because 
>> is smaller and more simple than previous logic. Also patch to spec
>> will be smaller.
> Yes, it's definitely much better than before.
>
> The only problem I see is that we add some overhead per fragment 
> (header). We could solve that with the mergeable buffers that Jiang is 
> considering for DGRAM.

If we are talking about receive, i think, i can reuse merge logic for

stream sockets, the only difference is that buffers are mergeable

until previous EOR(e.g. previous message) bit is found in rx queue.

>
> If we have that support, I think we could reuse it here as well, but it 
> might be a next step.
>
> Thanks,
> Stefano
>
>

  reply	other threads:[~2021-04-22  9:40 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 12:39 [RFC PATCH v8 00/19] virtio/vsock: introduce SOCK_SEQPACKET support Arseny Krasnov
2021-04-13 12:41 ` [RFC PATCH v8 01/19] af_vsock: update functions for connectible socket Arseny Krasnov
2021-04-13 12:42 ` [RFC PATCH v8 02/19] af_vsock: separate wait data loop Arseny Krasnov
2021-04-13 12:42 ` [RFC PATCH v8 03/19] af_vsock: separate receive " Arseny Krasnov
2021-04-13 12:42 ` [RFC PATCH v8 04/19] af_vsock: implement SEQPACKET receive loop Arseny Krasnov
2021-04-21  8:37   ` Stefano Garzarella
2021-04-21 14:47     ` Arseny Krasnov
2021-04-13 12:43 ` [RFC PATCH v8 05/19] af_vsock: implement send logic for SEQPACKET Arseny Krasnov
2021-04-13 12:43 ` [RFC PATCH v8 06/19] af_vsock: rest of SEQPACKET support Arseny Krasnov
2021-04-13 12:43 ` [RFC PATCH v8 07/19] af_vsock: update comments for stream sockets Arseny Krasnov
2021-04-13 12:43 ` [RFC PATCH v8 08/19] virtio/vsock: set packet's type in virtio_transport_send_pkt_info() Arseny Krasnov
2021-04-13 12:44 ` [RFC PATCH v8 09/19] virtio/vsock: simplify credit update function API Arseny Krasnov
2021-04-13 12:44 ` [RFC PATCH v8 10/19] virtio/vsock: defines and constants for SEQPACKET Arseny Krasnov
2021-04-13 12:44 ` [RFC PATCH v8 11/19] virtio/vsock: dequeue callback for SOCK_SEQPACKET Arseny Krasnov
2021-04-14  5:21   ` Arseny Krasnov
2021-04-21  8:56   ` Stefano Garzarella
2021-04-21 14:49     ` Arseny Krasnov
2021-04-13 12:45 ` [RFC PATCH v8 12/19] virtio/vsock: add SEQPACKET receive logic Arseny Krasnov
2021-04-13 12:45 ` [RFC PATCH v8 13/19] virtio/vsock: rest of SOCK_SEQPACKET support Arseny Krasnov
2021-04-21  9:12   ` Stefano Garzarella
2021-04-21 14:50     ` Arseny Krasnov
2021-04-13 12:45 ` [RFC PATCH v8 14/19] virtio/vsock: enable SEQPACKET for transport Arseny Krasnov
2021-04-21  9:22   ` Stefano Garzarella
2021-04-13 12:46 ` [RFC PATCH v8 15/19] vhost/vsock: " Arseny Krasnov
2021-04-21  9:31   ` Stefano Garzarella
2021-04-13 12:46 ` [RFC PATCH v8 16/19] vsock/loopback: " Arseny Krasnov
2021-04-21  9:34   ` Stefano Garzarella
2021-04-13 12:46 ` [RFC PATCH v8 17/19] vsock_test: add SOCK_SEQPACKET tests Arseny Krasnov
2021-04-21  9:35   ` Stefano Garzarella
2021-04-21 15:00     ` Arseny Krasnov
2021-04-13 12:47 ` [RFC PATCH v8 18/19] virtio/vsock: update trace event for SEQPACKET Arseny Krasnov
2021-04-13 12:47 ` [RFC PATCH v8 19/19] af_vsock: serialize writes to shared socket Arseny Krasnov
2021-04-14 10:51   ` Arseny Krasnov
2021-04-21  9:38     ` Stefano Garzarella
2021-04-21 15:02       ` Arseny Krasnov
2021-04-21  9:52 ` [RFC PATCH v8 00/19] virtio/vsock: introduce SOCK_SEQPACKET support Stefano Garzarella
2021-04-21 15:06   ` Arseny Krasnov
2021-04-22  8:46     ` Stefano Garzarella
2021-04-22  9:40       ` Arseny Krasnov [this message]
2021-04-22 10:02         ` Stefano Garzarella
2021-04-22 10:29           ` Arseny Krasnov
2021-04-22 10:48             ` Stefano Garzarella
2021-04-22 11:41               ` Arseny Krasnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfefdd94-a84f-8bed-331e-274654a7426f@kaspersky.com \
    --to=arseny.krasnov@kaspersky.com \
    --cc=alex.popov@linux.com \
    --cc=andraprs@amazon.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=jasowang@redhat.com \
    --cc=jhansen@vmware.com \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nslusarek@gmx.net \
    --cc=oxffffaa@gmail.com \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=stsp2@yandex.ru \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).