From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: linux-kselftest@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/kvm: add get_msr_index_features
Date: Thu, 18 Mar 2021 18:33:35 +0100 [thread overview]
Message-ID: <c08773f1-4b84-bb19-cda8-c8ac6ffffdaf@redhat.com> (raw)
In-Reply-To: <20210318170316.6vah7x2ws4bimmdf@kamzik.brq.redhat.com>
On 18/03/21 18:03, Andrew Jones wrote:
>>
>> TEST_GEN_PROGS_x86_64 = x86_64/cr4_cpuid_sync_test
>> +TEST_GEN_PROGS_x86_64 += x86_64/get_msr_index_features
>
> Maybe we should give up trying to keep an alphabetic order.
FWIW I had fixed that but yeah maybe we should just give up.
>> +int main(int argc, char *argv[])
>> +{
>> + if (kvm_check_cap(KVM_CAP_GET_MSR_FEATURES))
>> + test_get_msr_feature();
>> +
>> + test_get_msr_index();
> Missing return
>
>> +}
"main" is special, it's okay not to have a return there.
Paolo
next prev parent reply other threads:[~2021-03-18 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 14:56 [PATCH] selftests/kvm: add get_msr_index_features Emanuele Giuseppe Esposito
2021-03-18 15:35 ` Paolo Bonzini
2021-03-18 17:03 ` Andrew Jones
2021-03-18 17:33 ` Paolo Bonzini [this message]
2021-03-18 17:55 ` Andrew Jones
2021-03-18 18:46 ` Sean Christopherson
2021-03-19 8:07 ` Emanuele Giuseppe Esposito
2021-03-19 8:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c08773f1-4b84-bb19-cda8-c8ac6ffffdaf@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=eesposit@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).