From: Thomas Huth <thuth@redhat.com>
To: Collin Walling <walling@linux.ibm.com>, kvm@vger.kernel.org
Cc: frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com
Subject: Re: [PATCH v1] self_tests/kvm: sync_regs and reset tests for diag318
Date: Thu, 15 Oct 2020 18:14:01 +0200 [thread overview]
Message-ID: <c0db7f04-3511-8b55-9551-1da3befd04a3@redhat.com> (raw)
In-Reply-To: <99917e28-7c77-c7c3-5641-c711b107cf70@linux.ibm.com>
On 15/10/2020 17.26, Collin Walling wrote:
> On 10/15/20 3:55 AM, Thomas Huth wrote:
[...]
>>> @@ -206,6 +210,7 @@ static void test_normal(void)
>>> /* Create VM */
>>> vm = vm_create_default(VCPU_ID, 0, guest_code_initial);
>>> run = vcpu_state(vm, VCPU_ID);
>>> + run->s.regs.diag318 = get_diag318_info();
>>> sync_regs = &run->s.regs;
>>
>> Not sure, but don't you have to mark KVM_SYNC_DIAG318 in run->kvm_valid_regs
>> and run->kvm_dirty_regs here...
>
> Hmm... you're right. I need to do that...
>
> Looks like the normal reset case is failing now. I must've missed
> setting the value to 0 in KVM's normal reset handler...
>
> It's a one-line fix (and truthfully, there isn't much harm done). I'll
> toss it up on the list.
Even if it's just a small issue, it's always great to see that the KVM
selftests help to find bugs :-)
Thomas
next prev parent reply other threads:[~2020-10-15 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 19:27 [PATCH v1] self_tests/kvm: sync_regs and reset tests for diag318 Collin Walling
2020-10-15 7:55 ` Thomas Huth
2020-10-15 15:26 ` Collin Walling
2020-10-15 16:14 ` Thomas Huth [this message]
2020-10-15 12:40 ` Janosch Frank
2020-10-15 13:56 ` Thomas Huth
2020-10-16 6:58 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0db7f04-3511-8b55-9551-1da3befd04a3@redhat.com \
--to=thuth@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).