From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D540AC433E0 for ; Wed, 13 Jan 2021 07:39:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B19723333 for ; Wed, 13 Jan 2021 07:39:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726488AbhAMHj2 (ORCPT ); Wed, 13 Jan 2021 02:39:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:33717 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbhAMHj2 (ORCPT ); Wed, 13 Jan 2021 02:39:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610523482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vASVQk6CyeuqGmqPAo777fJFAsgxGMg2kZr0CGQiujs=; b=BJDI+BaPT+Ob6ni1/79iVfOJso+RaMbKk1issyQC7dRelnYqSOvJzt8uFFFZQ9m93tibF1 j7ZW78WsNG1F/eW96IfA78K6+kLlZ1U1vWVQhSuVIhZYisPCEe+ZowyKJyyGl8d8Anf1fs Yh8VMNJ6tYISsh0XslzFu+7E1Abphow= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590--7PEjkhWPR-znfObeI4NFA-1; Wed, 13 Jan 2021 02:38:00 -0500 X-MC-Unique: -7PEjkhWPR-znfObeI4NFA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C934802B40; Wed, 13 Jan 2021 07:37:59 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-122.ams2.redhat.com [10.36.112.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id BD6135D9DD; Wed, 13 Jan 2021 07:37:53 +0000 (UTC) Subject: Re: [PATCH 2/6] KVM: selftests: Avoid flooding debug log while populating memory To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Paolo Bonzini , Peter Xu , Andrew Jones , Peter Shier , Sean Christopherson , Jacob Xu , Makarand Sonare References: <20210112214253.463999-1-bgardon@google.com> <20210112214253.463999-3-bgardon@google.com> From: Thomas Huth Message-ID: Date: Wed, 13 Jan 2021 08:37:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210112214253.463999-3-bgardon@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 12/01/2021 22.42, Ben Gardon wrote: > Peter Xu pointed out that a log message printed while waiting for the > memory population phase of the dirty_log_perf_test will flood the debug > logs as there is no delay after printing the message. Since the message > does not provide much value anyway, remove it. > > Reviewed-by: Jacob Xu > > Signed-off-by: Ben Gardon > --- > tools/testing/selftests/kvm/dirty_log_perf_test.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c > index 16efe6589b43..15a9c45bdb5f 100644 > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > @@ -146,8 +146,7 @@ static void run_test(enum vm_guest_mode mode, void *arg) > /* Allow the vCPU to populate memory */ > pr_debug("Starting iteration %lu - Populating\n", iteration); > while (READ_ONCE(vcpu_last_completed_iteration[vcpu_id]) != iteration) > - pr_debug("Waiting for vcpu_last_completed_iteration == %lu\n", > - iteration); > + ; > > ts_diff = timespec_elapsed(start); > pr_info("Populate memory time: %ld.%.9lds\n", > @@ -171,9 +170,9 @@ static void run_test(enum vm_guest_mode mode, void *arg) > > pr_debug("Starting iteration %lu\n", iteration); > for (vcpu_id = 0; vcpu_id < nr_vcpus; vcpu_id++) { > - while (READ_ONCE(vcpu_last_completed_iteration[vcpu_id]) != iteration) > - pr_debug("Waiting for vCPU %d vcpu_last_completed_iteration == %lu\n", > - vcpu_id, iteration); > + while (READ_ONCE(vcpu_last_completed_iteration[vcpu_id]) > + != iteration) > + ; > } > > ts_diff = timespec_elapsed(start); > Reviewed-by: Thomas Huth