From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D9EDC433E0 for ; Tue, 7 Jul 2020 11:24:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16EA820739 for ; Tue, 7 Jul 2020 11:24:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727826AbgGGLYZ (ORCPT ); Tue, 7 Jul 2020 07:24:25 -0400 Received: from foss.arm.com ([217.140.110.172]:41650 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727044AbgGGLYY (ORCPT ); Tue, 7 Jul 2020 07:24:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 503631FB; Tue, 7 Jul 2020 04:24:24 -0700 (PDT) Received: from [192.168.0.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2B04C3F71E; Tue, 7 Jul 2020 04:24:22 -0700 (PDT) Subject: Re: [PATCH v3 00/17] KVM: arm64: Preliminary NV patches To: Marc Zyngier , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Cc: Andre Przywara , Christoffer Dall , Dave Martin , Jintack Lim , George Cherian , "Zengtao (B)" , Andrew Scull , Will Deacon , Mark Rutland , James Morse , Julien Thierry , Suzuki K Poulose , kernel-team@android.com References: <20200706125425.1671020-1-maz@kernel.org> From: Alexandru Elisei Message-ID: Date: Tue, 7 Jul 2020 12:24:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200706125425.1671020-1-maz@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi, On 7/6/20 1:54 PM, Marc Zyngier wrote: > Hi all, > > In order not to repeat the 90+ patch series that resulted in a > deafening silence last time, I've extracted a smaller set of patches > that form the required dependencies that allow the rest of the 65 NV > patches to be added on top. Yes, it is that bad. > > The one real feature here is support for the ARMv8.4-TTL extension at > Stage-2 only. The reason to support it is that it helps the hypervisor > a lot when it comes to finding out how much to invalidate. It is thus > always "supported" with NV. > > The rest doesn't contain any functionality change. Most of it reworks > existing data structures and adds new accessors for the things that > get moved around. The reason for this is that: > > - With NV, we end-up with multiple Stage-2 MMU contexts per VM instead > of a single one. This requires we divorce struct kvm from the S2 MMU > configuration. Of course, we stick with a single MMU context for now. > > - With ARMv8.4-NV, a number of system register accesses are turned > into memory accesses into the so-called VNCR page. It is thus > convenient to make this VNCR page part of the vcpu context and avoid > copying data back and forth. For this to work, we need to make sure > that all the VNCR-aware sysregs are moved into our per-vcpu sys_regs > array instead of leaving in other data structures (the timers, for > example). The VNCR page itself isn't introduced with these patches. > > - As some of these data structures change, we need a way to isolate > the userspace ABI from such change. > > There is also a number of cleanups that were in the full fat series > that I decided to move early to get them out of the way. > > The whole this is a bit of a mix of vaguely unrelated "stuff", but it > all comes together if you look at the final series. This applies on > top of David Brazdil's series splitting the VHE and nVHE objects. > > I plan on taking this early into v5.9, and I really mean it this time! > > Catalin: How do you want to proceed for patches 2, 3, and 4? I could > make a stable branch that gets you pull into the arm64 tree, or the > other way around. Just let me know. > > Thanks, > > M. > > * From v2: > - Rebased on top of David's el2-obj series I tried to apply the patches on top of v5.8-rc1, but I get a conflict on the very first patch. I guess it's because I don't have the el2-obj series. Is that v4 of "Split off nVHE hyp code" patches from David Brazil? Thanks, Alex