From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>, kvm@vger.kernel.org
Subject: Re: [PATCH 0/3] accel: Remove system-mode stubs from user-mode builds
Date: Mon, 9 Nov 2020 11:50:02 +0100 [thread overview]
Message-ID: <c5d2bedf-20f7-c5ae-4c64-5ac8e4706949@redhat.com> (raw)
In-Reply-To: <20201109094547.2456385-1-f4bug@amsat.org>
On 09/11/20 10:45, Philippe Mathieu-Daudé wrote:
> It is pointless to build/link these stubs into user-mode binaries.
>
> Philippe Mathieu-Daudé (3):
> accel: Only include TCG stubs in user-mode only builds
> accel/stubs: Restrict system-mode emulation stubs
> accel/stubs: Simplify kvm-stub.c
>
> accel/stubs/kvm-stub.c | 5 -----
> accel/meson.build | 10 ++++++----
> accel/stubs/meson.build | 12 ++++++++----
> 3 files changed, 14 insertions(+), 13 deletions(-)
>
The series makes sense. It probably also shows that it makes sense to
have a "specific_softmmu_ss" sourceset in meson.build. Let's review
Alex Bennée's patches and then get back to this one.
Paolo
prev parent reply other threads:[~2020-11-09 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:45 [PATCH 0/3] accel: Remove system-mode stubs from user-mode builds Philippe Mathieu-Daudé
2020-11-09 9:45 ` [PATCH 1/3] accel: Only include TCG stubs in user-mode only builds Philippe Mathieu-Daudé
2020-11-09 9:55 ` Claudio Fontana
2020-11-09 10:48 ` Paolo Bonzini
2020-11-09 9:45 ` [PATCH 2/3] accel/stubs: Restrict system-mode emulation stubs Philippe Mathieu-Daudé
2020-11-09 9:56 ` Claudio Fontana
2020-11-09 9:45 ` [PATCH 3/3] accel/stubs: Simplify kvm-stub.c Philippe Mathieu-Daudé
2020-11-09 10:50 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5d2bedf-20f7-c5ae-4c64-5ac8e4706949@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=kvm@vger.kernel.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).