From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA26CC48BC2 for ; Mon, 21 Jun 2021 23:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE36F60FE7 for ; Mon, 21 Jun 2021 23:35:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231883AbhFUXiL (ORCPT ); Mon, 21 Jun 2021 19:38:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58901 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231888AbhFUXiK (ORCPT ); Mon, 21 Jun 2021 19:38:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624318555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y4rj5S7DFpUC+3DesUoe15Y9dUe8dzdqWSEsCDEqvgA=; b=APC7UXMuV7Au63FUsCMO9Q282eUDQEYwVP6WEwBIpcNACtEU6q35IBZpXxT0Tl1c8gRw3B ZfTWWxZJEHP3vYgUhWVabQ0OkNLeM2z0aCJDGdDbUN7ynhtmi/BYFTLIMedOMPcQ0i19as MYGb9+SLpvUYyhqYAANmlkVvnTJCfXc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-190-SgvvdLXlMxWiy_hJ1MIVug-1; Mon, 21 Jun 2021 19:35:54 -0400 X-MC-Unique: SgvvdLXlMxWiy_hJ1MIVug-1 Received: by mail-wm1-f71.google.com with SMTP id h9-20020a05600c3509b02901b985251fdcso113719wmq.9 for ; Mon, 21 Jun 2021 16:35:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y4rj5S7DFpUC+3DesUoe15Y9dUe8dzdqWSEsCDEqvgA=; b=PtNj8jt6eZdyaxFPanXLyKSoomNByhhBHGQ/ZMk1NG0rHUrNqjE41TopLP3Q4ZlYPt Mw2cGuuRUxRp9k+LcFbh5Qw1BPEchPMmmND1L28EkLwQBnolZr4EhYjqWhlPkfRpoPac NrAmyATToWfZMpn+Oen4uzsIyZgZCPsXqvpSYOeAUT0LEGddQq0BMp5/YFAYpjZNx88H hBsEibc2ToPkGDiuJt1lEH0YJRjwF0IjlE6Z7sePTT2OuQ+/CHSoh8kZdr23QdBzh4vx XUPYM8t3+x00Quh9aw4oaZNV98OncG0dtxBzrRFhdsjz7eZk/2/G9r9ACpHJnI6UpaoM 0Ydw== X-Gm-Message-State: AOAM530adz80E8ttmqWGkO/AV1o+FguvGJXWKpqau6KkfF//q11WVRcd lksLkdp28kf7omZCwo/yUPgE3Mo+srTpW5bYNcLzKGj0csHhFBUzWYq/Cw9LS8G+9WpLiFWbTop WAR1OcPOwulVv X-Received: by 2002:a05:6000:1c5:: with SMTP id t5mr1064346wrx.71.1624318553282; Mon, 21 Jun 2021 16:35:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhLPASIEPgENpXabVu2lLjBJcoZDTjIn3uO5++5JKzeF1Zgk0yuFtAQij55J0dmy/ecQX5WA== X-Received: by 2002:a05:6000:1c5:: with SMTP id t5mr1064334wrx.71.1624318553129; Mon, 21 Jun 2021 16:35:53 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id u15sm458337wmq.48.2021.06.21.16.35.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 16:35:52 -0700 (PDT) Subject: Re: [PATCH v12 2/7] KVM: stats: Add fd-based API to read binary stats data To: Jing Zhang Cc: KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan , Fuad Tabba , Greg KH References: <20210618222709.1858088-1-jingzhangos@google.com> <20210618222709.1858088-3-jingzhangos@google.com> <0cde024e-a234-9a10-5157-d17ba423939e@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 22 Jun 2021 01:35:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 22/06/21 00:58, Jing Zhang wrote: >> Pass it as an argument? > The num_desc can only be initialized in the same file that defines the > descriptor array. > Looks like we have to have a global variable to save that. The > solution would be similar > to have a statically defined header for each arch. > So, keep the header structure for each arch? Oh, sorry. I missed that there's only one call to kvm_stats_read and it's in common code. The remaining comments are small enough that I can apply them myself. Thanks! Paolo